mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-14 05:25:44 +00:00
Incorrect output of number of processed frames and progress #101
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @workflowsguy on GitHub (Dec 23, 2015).
Originally assigned to: @canihavesomecoffee on GitHub.
Since Version 0.78,
ccextractor always outputs
"Total frames time: 00:00:00:000 (0 frames at 29.97fps)"
even when it successfully extracts subtitles.
Also, the progress output is no longer correct. It will output lines like this:
88% | 00:00
89% | 606:29
90% | 607:10
91% | 608:09
92% | 00:00
93% | 00:00
94% | 611:10
95% | 612:04
96% | 612:53
97% | 613:45
98% | 614:24
99% | 615:06
100% | 00:00
I am using the command line version on OS X provided through Homebrew.
@hurda commented on GitHub (Dec 26, 2015):
And it's also showing 29.97fps when the source-material is 50p.
@anshul1912 commented on GitHub (Dec 26, 2015):
@hurda can you provide sample
@cfsmp3 commented on GitHub (Jan 7, 2016):
@workflowsguy we need a sample to test this - otherwise the ticket will be closed soon
@workflowsguy commented on GitHub (Jan 8, 2016):
Here is a sample:
https://www.dropbox.com/s/h53kaujpvjwdh69/Quarks%20%26%20Co.mpg?dl=0
It is a video clip in MP4 MPEG-TS format with both german teletext subtitles on page 150 and DVB-S subtitles. It was recorded with Elgato's EyeTV on OS X.
CCExtractor successfully extracts teletext subtitles but shows "Total frames time: 00:00:00:000 (0 frames at 29.97fps)". Also, various tools report the true fps rate of the file to be 50 fps.
Note that this sample (surprisingly) does not show the incorrect timestamp output that I reported above. If I find one, I will also post the link.
Thanks!
@hurda commented on GitHub (Jan 8, 2016):
You can use the sample from https://github.com/CCExtractor/ccextractor/issues/249 , (720p50 H264)
@anshul1912 commented on GitHub (Jan 9, 2016):
This problem main reason is that these teletext subs does not of have frames but have packets (which are displayed) and no fix frame rate to calculate the total time,
so I have removed that print when its not atsc closed caption
@workflowsguy commented on GitHub (Feb 2, 2016):
In CCExtractor 0.79, there still are incorrect timecodes for the progress output.
@workflowsguy commented on GitHub (Feb 9, 2016):
Honestly, I don't like the "fix" for this issue.
Previously, I parsed the output for the number of frames produced to detect if there were subtitles extracted.
Now, there seems no longer to be an easy way to detect this. It cannot be detected from the return code and not from the presence of a srt file.
@cfsmp3 commented on GitHub (Nov 7, 2016):
@workflowsguy we're going to assign this task to a student during Code-in (which starts in 2 weeks).
We need details of the current status and your proposed solution (i.e. a description of what the correct behavior would be).
@workflowsguy commented on GitHub (Nov 8, 2016):
This is good to hear!
I see this as two related issues:
But I consider this a more cosmetic issue as I used this as a workaround for the following issue.
a) not create a srt file at all (instead of a 3 byte file as it does now)
b) return a non-zero result code to indicate failure (instead of "0" = "success" as it does now) in conformance with the conventions for command line tools.
This should allow for easier processing in shell script-based workflows.
Thanks!
@cfsmp3 commented on GitHub (Nov 9, 2016):
Code-in task created.
@cfsmp3 commented on GitHub (Jan 20, 2017):
GSOC qualification: This issue gives 2 points.
@saurabhshri commented on GitHub (Dec 2, 2018):
Hi @workflowsguy ! The sample link is dead, could you please update it? We have some GCI students who want to work on this issue. Thanks!
@workflowsguy commented on GitHub (Dec 2, 2018):
Hello @saurabhshri,
I am confused as what you are trying to do with this issue. The issue of outputting an incorrect timecode has long since been solved.
The other problem of completely parsing the streams even when there are no teletext subtitles is still unsolved in 0.87 even though @lzaron has closed it. There is no such switch
--noemptyin cc as far as I can see.I will be happy to help, but be grateful if someone could clarify how this issue will be addressed.
@saurabhshri commented on GitHub (Dec 2, 2018):
@workflowsguy We knew that appearance of incorrect frames and FPS was resolved [
"Total frames time: 00:00:00:000 (0 frames at 29.97fps)"], but we weren't sure if the timecodes were fine too. Since, we were unable to re-produce that with any of our samples, I requested for the original sample to see if the problem still exists.Thanks for letting us know that it's resolved.
Regarding
--noemptyparameter, some students attempted the task - but the implementation wasn't the ideal one. So, that issue is still up for grab.PS @Izaron hasn't closed the issue, the PR was closed as the approach wasn't deemed fit. The issue is still open.
@cfsmp3 commented on GitHub (Dec 2, 2018):
@workflowsguy so can this specific github issue be closed?
@workflowsguy commented on GitHub (Dec 5, 2018):
@cfsmp3,
yes, thank you. I will close it.