[PR #168] [MERGED] Add iconv to EXTRA_LIBS in CMakeLists. #1055

Closed
opened 2026-01-29 16:58:42 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/168
Author: @codeman38
Created: 5/24/2015
Status: Merged
Merged: 5/27/2015
Merged by: @cfsmp3

Base: masterHead: missing-iconv


📝 Commits (1)

  • 80303dd Add iconv to EXTRA_LIBS in CMakeLists.

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/CMakeLists.txt (+1 -0)

📄 Description

Compilation via cmake fails on OS X if libiconv is not specified as a required library:

Undefined symbols for architecture x86_64:
  "_iconv", referenced from:
      _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o)
  "_iconv_close", referenced from:
      _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o)
  "_iconv_open", referenced from:
      _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Adding it to EXTRA_LIBS in CMakeLists.txt is enough to make compilation successful.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/168 **Author:** [@codeman38](https://github.com/codeman38) **Created:** 5/24/2015 **Status:** ✅ Merged **Merged:** 5/27/2015 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `missing-iconv` --- ### 📝 Commits (1) - [`80303dd`](https://github.com/CCExtractor/ccextractor/commit/80303ddde51d830c49c2dfef4b24ee404debbeba) Add iconv to EXTRA_LIBS in CMakeLists. ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/CMakeLists.txt` (+1 -0) </details> ### 📄 Description Compilation via cmake fails on OS X if libiconv is not specified as a required library: ``` Undefined symbols for architecture x86_64: "_iconv", referenced from: _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o) "_iconv_close", referenced from: _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o) "_iconv_open", referenced from: _EPG_DVB_decode_string in libccx.a(ts_tables_epg.c.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` Adding it to EXTRA_LIBS in CMakeLists.txt is enough to make compilation successful. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:58:42 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1055