[PR #300] [CLOSED] Fixed issue #288 : Segfault on using -sc for a blank line #1141

Closed
opened 2026-01-29 16:59:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/300
Author: @Abhinav95
Created: 3/8/2016
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 0089901 Fixed segfault on using -sc for a blank line

📊 Changes

1 file changed (+20 additions, -0 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_helpers.c (+20 -0)

📄 Description

The seg-fault would happen if the value of string p1 or p2 is null, which happens in a blank line. Returning a non-zero value for string_cmp2 (1 chosen arbitrarily here) if the null case happens prevents the seg-fault from happening.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/300 **Author:** [@Abhinav95](https://github.com/Abhinav95) **Created:** 3/8/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`0089901`](https://github.com/CCExtractor/ccextractor/commit/0089901b07581779158f5974c22b5884d4717637) Fixed segfault on using -sc for a blank line ### 📊 Changes **1 file changed** (+20 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_helpers.c` (+20 -0) </details> ### 📄 Description The seg-fault would happen if the value of string p1 or p2 is null, which happens in a blank line. Returning a non-zero value for string_cmp2 (1 chosen arbitrarily here) if the null case happens prevents the seg-fault from happening. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:59:44 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1141