[PR #453] GCI: Clean up function names and refactor some code. #1269

Open
opened 2026-01-29 17:00:45 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/453

State: closed
Merged: No


Aside from renaming hex2int --> hex_to_int and processhex --> process_hex for consistency, I also took the liberty to implement a hex_string_to_int function. It seems like hexadecimal characters are accessed from a string before being passed to hex_to_int, so it seems logical to eliminate that extra step and generalize the behavior a bit more. I did not introduce the new hex_string_to_int function into existing code to make sure it's reviewed before it's used.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/453 **State:** closed **Merged:** No --- Aside from renaming hex2int --> hex_to_int and processhex --> process_hex for consistency, I also took the liberty to implement a hex_string_to_int function. It seems like hexadecimal characters are accessed from a string before being passed to hex_to_int, so it seems logical to eliminate that extra step and generalize the behavior a bit more. I did not introduce the new hex_string_to_int function into existing code to make sure it's reviewed before it's used.
claunia added the pull-request label 2026-01-29 17:00:45 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1269