[PR #475] [MERGED] Fixed bug with -out=null #1292

New Issue

claunia · 2026-01-29T17:00:54Z

claunia commented

2026-01-29 17:00:54 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/475
Author: @Izaron
Created: 12/3/2016
Status: ✅ Merged
Merged: 12/5/2016
Merged by: @cfsmp3

Base: master ← Head: out-null-bug

📝 Commits (1)

764c890 Fixed bug with -out=null

📊 Changes

2 files changed (+10 additions, -6 deletions)

View changed files

📝 src/lib_ccx/general_loop.c (+9 -5)
📝 src/lib_ccx/lib_ccx.c (+1 -1)

📄 Description

https://codein.withgoogle.com/dashboard/task-instances/5591734023094272/

I checked the correctness (I had segfault too).
Falling test - the only test that has an argument -out=null. But I checked some other files, and they too gave segfault with -out=null.
How is it? Firstly, after this line #1 enc_ctx becomes NULL (from function #2), and we get an error in this line #3
If we run it with other files, then we almost always get an segfault error in other places associated with the fact that enc_ctx = NULL.
I have added the necessary checks, and now works well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/475 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 12/3/2016 **Status:** ✅ Merged **Merged:** 12/5/2016 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `out-null-bug` --- ### 📝 Commits (1) - [`764c890`](https://github.com/CCExtractor/ccextractor/commit/764c8908925787b4d7bf882404e144dd2c1db0a1) Fixed bug with -out=null ### 📊 Changes **2 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/general_loop.c` (+9 -5) 📝 `src/lib_ccx/lib_ccx.c` (+1 -1) </details> ### 📄 Description [https://codein.withgoogle.com/dashboard/task-instances/5591734023094272/](url) I checked the correctness (I had segfault too). Falling test - the only test that has an argument `-out=null`. But I checked some other files, and they too gave segfault with `-out=null`. How is it? Firstly, after this line [#1](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/general_loop.c#L930) `enc_ctx` becomes NULL (from function [#2](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/lib_ccx.c#L332)), and we get an error in this line [#3](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/general_loop.c#L933) If we run it with other files, then we almost always get an segfault error in other places associated with the fact that `enc_ctx = NULL`. I have added the necessary checks, and now works well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:00:54 +00:00

claunia closed this issue

2026-01-29 17:00:54 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1292