[PR #480] [CLOSED] Re-attempt function cleanup. #1295

New Issue

claunia · 2026-01-29T17:00:55Z

claunia commented

2026-01-29 17:00:55 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/480
Author: @DanilaFe
Created: 12/5/2016
Status: ❌ Closed

Base: master ← Head: function-cleanup-redone

📝 Commits (10+)

4705115 Rename processhex to process_hex for consistency.
a10c550 Rename hex2int to hex_to_int.
8f1dbe0 Add hex_string_to_int function.
a100d06 Remove accidental code duplication.
fa27ee9 Rename i, u, se, and ue functions.
d50a54a Rename mstotime to millis_to_time.
c1b39e7 Add underscores to debug_608toASC.
e4877a0 Refactor code surrounding print_mstime_static.
b8b34fa Rename function to new name.
412deb0 Rename more mstotime's to millis_to_time.

📊 Changes

48 files changed (+674 additions, -682 deletions)

View changed files

📝 src/ccextractor.c (+28 -28)
📝 src/lib_ccx/asf_functions.c (+207 -207)
📝 src/lib_ccx/avc_functions.c (+174 -173)
📝 src/lib_ccx/avc_functions.h (+2 -2)
📝 src/lib_ccx/bitstream.h (+4 -4)
📝 src/lib_ccx/cc_bitstream.c (+5 -5)
📝 src/lib_ccx/ccx_common_common.c (+2 -2)
📝 src/lib_ccx/ccx_common_common.h (+2 -2)
📝 src/lib_ccx/ccx_common_timing.c (+14 -34)
📝 src/lib_ccx/ccx_common_timing.h (+3 -4)
📝 src/lib_ccx/ccx_decoders_608.c (+2 -2)
📝 src/lib_ccx/ccx_decoders_708.c (+14 -14)
📝 src/lib_ccx/ccx_decoders_708_output.c (+6 -6)
📝 src/lib_ccx/ccx_decoders_common.c (+9 -9)
📝 src/lib_ccx/ccx_decoders_common.h (+1 -1)
📝 src/lib_ccx/ccx_demuxer.c (+2 -2)
📝 src/lib_ccx/ccx_demuxer.h (+9 -9)
📝 src/lib_ccx/ccx_encoders_common.c (+4 -4)
📝 src/lib_ccx/ccx_encoders_curl.c (+2 -2)
📝 src/lib_ccx/ccx_encoders_g608.c (+2 -2)

...and 28 more files

📄 Description

It seems like one of my commits some time across the previous cleanup (PR #453) broke the build. The sheer volume of changes done makes it hard to backtrack, so I will be cherry picking the individual commits and seeing which ones caused the issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/480 **Author:** [@DanilaFe](https://github.com/DanilaFe) **Created:** 12/5/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `function-cleanup-redone` --- ### 📝 Commits (10+) - [`4705115`](https://github.com/CCExtractor/ccextractor/commit/4705115ecd113dce8316acd3d44f9b2d9e1c842b) Rename processhex to process_hex for consistency. - [`a10c550`](https://github.com/CCExtractor/ccextractor/commit/a10c550f143e142e0136c08f8826fc07242f3aa0) Rename hex2int to hex_to_int. - [`8f1dbe0`](https://github.com/CCExtractor/ccextractor/commit/8f1dbe05d4c4696f74a0261600459db3308fd18e) Add hex_string_to_int function. - [`a100d06`](https://github.com/CCExtractor/ccextractor/commit/a100d06fd55aabd0a69c362c9bd3502fe48b5c5a) Remove accidental code duplication. - [`fa27ee9`](https://github.com/CCExtractor/ccextractor/commit/fa27ee9fcbe9f76ca21d801813274c89f7a77771) Rename i, u, se, and ue functions. - [`d50a54a`](https://github.com/CCExtractor/ccextractor/commit/d50a54ab576fefeb436239eb2fc0a26e0cb3f4da) Rename mstotime to millis_to_time. - [`c1b39e7`](https://github.com/CCExtractor/ccextractor/commit/c1b39e771714fc5ff3d0d4d56a0ada8d4547d289) Add underscores to debug_608toASC. - [`e4877a0`](https://github.com/CCExtractor/ccextractor/commit/e4877a0c9716f799599a4786c8a866ac628edaeb) Refactor code surrounding print_mstime_static. - [`b8b34fa`](https://github.com/CCExtractor/ccextractor/commit/b8b34fa6e992498ac6455fdb29a8a6be4bea7021) Rename function to new name. - [`412deb0`](https://github.com/CCExtractor/ccextractor/commit/412deb01e544d9630a05969f8486586797379cc1) Rename more mstotime's to millis_to_time. ### 📊 Changes **48 files changed** (+674 additions, -682 deletions) <details> <summary>View changed files</summary> 📝 `src/ccextractor.c` (+28 -28) 📝 `src/lib_ccx/asf_functions.c` (+207 -207) 📝 `src/lib_ccx/avc_functions.c` (+174 -173) 📝 `src/lib_ccx/avc_functions.h` (+2 -2) 📝 `src/lib_ccx/bitstream.h` (+4 -4) 📝 `src/lib_ccx/cc_bitstream.c` (+5 -5) 📝 `src/lib_ccx/ccx_common_common.c` (+2 -2) 📝 `src/lib_ccx/ccx_common_common.h` (+2 -2) 📝 `src/lib_ccx/ccx_common_timing.c` (+14 -34) 📝 `src/lib_ccx/ccx_common_timing.h` (+3 -4) 📝 `src/lib_ccx/ccx_decoders_608.c` (+2 -2) 📝 `src/lib_ccx/ccx_decoders_708.c` (+14 -14) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+6 -6) 📝 `src/lib_ccx/ccx_decoders_common.c` (+9 -9) 📝 `src/lib_ccx/ccx_decoders_common.h` (+1 -1) 📝 `src/lib_ccx/ccx_demuxer.c` (+2 -2) 📝 `src/lib_ccx/ccx_demuxer.h` (+9 -9) 📝 `src/lib_ccx/ccx_encoders_common.c` (+4 -4) 📝 `src/lib_ccx/ccx_encoders_curl.c` (+2 -2) 📝 `src/lib_ccx/ccx_encoders_g608.c` (+2 -2) _...and 28 more files_ </details> ### 📄 Description It seems like one of my commits some time across the previous cleanup (PR #453) broke the build. The sheer volume of changes done makes it hard to backtrack, so I will be cherry picking the individual commits and seeing which ones caused the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:00:55 +00:00

claunia referenced this issue

2026-01-29 17:20:10 +00:00

[PR #1295] [MERGED] [DOCS] Documentation fix and mentioned alternatives that ccx accepts for -stdin and -cc2 options #2077

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1295