XDS not working #137

Closed
opened 2026-01-29 16:36:11 +00:00 by claunia · 0 comments
Owner

Originally created by @cfsmp3 on GitHub (Mar 28, 2016).

The following parameters

-out=txt -xdsdebug "F:\ConBackup\Closed captions\CC\Samples variados\Correct\With XDS\Survivor S23E01 1080i HDTV DD5.1 MPEG2.ts"

should produce XDS. However, in the function
void do_end_of_xds (struct cc_subtitle *sub, struct ccx_decoders_xds_context *ctx, unsigned char expected_checksum)

ctx is passed NULL in the call from
do_end_of_xds (sub, dec_ctx->xds_ctx, lo);

Which in turn can be traced here (in ccx_decoders_common.c)
// Init XDS buffers
if(setting->ignore_xds == CCX_TRUE)
ctx->xds_ctx = NULL;
else
ctx->xds_ctx = ccx_decoders_xds_init_library(ctx->timing);

etc

Anyway XDS needs to be processed regardless of whether it's going to be exported to a final text file or not, because XDS carries the program name, station name and more which can be used for other things than write this data to file. For starters the GUI use them to show the information to the user.

GSoC points: 3 (for a perfect solution in which XDS is processed but only written to file in the formats in which is makes sense, obviously not in .srt etc)

Originally created by @cfsmp3 on GitHub (Mar 28, 2016). The following parameters -out=txt -xdsdebug "F:\ConBackup\Closed captions\CC\Samples variados\Correct\With XDS\Survivor S23E01 1080i HDTV DD5.1 MPEG2.ts" should produce XDS. However, in the function void do_end_of_xds (struct cc_subtitle *sub, struct ccx_decoders_xds_context *ctx, unsigned char expected_checksum) ctx is passed NULL in the call from do_end_of_xds (sub, dec_ctx->xds_ctx, lo); Which in turn can be traced here (in ccx_decoders_common.c) // Init XDS buffers if(setting->ignore_xds == CCX_TRUE) ctx->xds_ctx = NULL; else ctx->xds_ctx = ccx_decoders_xds_init_library(ctx->timing); etc Anyway XDS needs to be processed _regardless_ of whether it's going to be exported to a final text file or not, because XDS carries the program name, station name and more which can be used for other things than write this data to file. For starters the GUI use them to show the information to the user. GSoC points: 3 (for a perfect solution in which XDS is processed but only written to file in the formats in which is makes sense, obviously not in .srt etc)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#137