[PR #545] [MERGED] Added configurable curl post url #1377

Open
opened 2026-01-29 17:16:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/545
Author: @Izaron
Created: 12/16/2016
Status: Merged
Merged: 12/16/2016
Merged by: @cfsmp3

Base: masterHead: curl


📝 Commits (1)

  • 5d8ce8b Added configurable curl post url

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 src/lib_ccx/ccx_common_option.h (+2 -0)
📝 src/lib_ccx/ccx_encoders_curl.c (+5 -1)

📄 Description

To compile with WITH_LIBCURL add in linux/build "-DWITH_LIBCURL" in BLD_FLAGS and "-l curl" in BLD_LINKER.

After code research, I added support for configurable cURL post URL. Already implemented options is "-out=curl" and "-curlposturl [URL]".
It was quite simple, because I used a global variable ccx_options.

But there are problem areas. My suggestions:

  1. How much reasonable this line in code architecture? Line. The same variable belongs to two objects, one of which belongs to another.
  2. It may be worthwhile to make the default curl post url? Instead of line. Maybe we need to look at the most frequent URL in tutorials about local servers.
  3. In one of my example videos after Done, processing time = 44 seconds This is beta software. Report issues to carlos at ccextractor org...
    I get *** Error in './ccextractor': free(): invalid pointer: 0x00007f49893e9c18 *** and backtrace. And it happens in current master. I can explore it if you want. Sample video - Link

Please, write what you think about it, thanks!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/545 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 12/16/2016 **Status:** ✅ Merged **Merged:** 12/16/2016 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `curl` --- ### 📝 Commits (1) - [`5d8ce8b`](https://github.com/CCExtractor/ccextractor/commit/5d8ce8bfb8c0023844d905ccbcd8026826732473) Added configurable curl post url ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_option.h` (+2 -0) 📝 `src/lib_ccx/ccx_encoders_curl.c` (+5 -1) </details> ### 📄 Description To compile with WITH_LIBCURL add in linux/build "-DWITH_LIBCURL" in BLD_FLAGS and "-l curl" in BLD_LINKER. After code research, I added support for configurable cURL post URL. Already implemented options is "-out=curl" and "-curlposturl [URL]". It was quite simple, because I used a global variable `ccx_options`. But there are problem areas. My suggestions: 1. How much reasonable this line in code architecture? [Line](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L2246). The same variable belongs to two objects, one of which belongs to another. 2. It may be worthwhile to make the default curl post url? Instead of [line](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L2212). Maybe we need to look at the most frequent URL in tutorials about local servers. 3. In one of my example videos after ``` Done, processing time = 44 seconds This is beta software. Report issues to carlos at ccextractor org... ``` I get `*** Error in './ccextractor': free(): invalid pointer: 0x00007f49893e9c18 ***` and backtrace. And it happens in current master. I can explore it if you want. Sample video - [Link](https://drive.google.com/file/d/0B0DIrRkpdn12MmZBckw0N3cwNnc/view) Please, write what you think about it, thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:16:06 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1377