[PR #545] Added configurable curl post url #1380

Open
opened 2026-01-29 17:16:07 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/545

State: closed
Merged: Yes


To compile with WITH_LIBCURL add in linux/build "-DWITH_LIBCURL" in BLD_FLAGS and "-l curl" in BLD_LINKER.

After code research, I added support for configurable cURL post URL. Already implemented options is "-out=curl" and "-curlposturl [URL]".
It was quite simple, because I used a global variable ccx_options.

But there are problem areas. My suggestions:

  1. How much reasonable this line in code architecture? Line. The same variable belongs to two objects, one of which belongs to another.
  2. It may be worthwhile to make the default curl post url? Instead of line. Maybe we need to look at the most frequent URL in tutorials about local servers.
  3. In one of my example videos after Done, processing time = 44 seconds This is beta software. Report issues to carlos at ccextractor org...
    I get *** Error in './ccextractor': free(): invalid pointer: 0x00007f49893e9c18 *** and backtrace. And it happens in current master. I can explore it if you want. Sample video - Link

Please, write what you think about it, thanks!

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/545 **State:** closed **Merged:** Yes --- To compile with WITH_LIBCURL add in linux/build "-DWITH_LIBCURL" in BLD_FLAGS and "-l curl" in BLD_LINKER. After code research, I added support for configurable cURL post URL. Already implemented options is "-out=curl" and "-curlposturl [URL]". It was quite simple, because I used a global variable `ccx_options`. But there are problem areas. My suggestions: 1. How much reasonable this line in code architecture? [Line](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L2246). The same variable belongs to two objects, one of which belongs to another. 2. It may be worthwhile to make the default curl post url? Instead of [line](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L2212). Maybe we need to look at the most frequent URL in tutorials about local servers. 3. In one of my example videos after ``` Done, processing time = 44 seconds This is beta software. Report issues to carlos at ccextractor org... ``` I get `*** Error in './ccextractor': free(): invalid pointer: 0x00007f49893e9c18 ***` and backtrace. And it happens in current master. I can explore it if you want. Sample video - [Link](https://drive.google.com/file/d/0B0DIrRkpdn12MmZBckw0N3cwNnc/view) Please, write what you think about it, thanks!
claunia added the pull-request label 2026-01-29 17:16:07 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1380