[PR #549] [MERGED] Fixed bug with -udp address #1383

New Issue

claunia · 2026-01-29T17:16:07Z

claunia commented

2026-01-29 17:16:07 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/549
Author: @Izaron
Created: 12/17/2016
Status: ✅ Merged
Merged: 12/22/2016
Merged by: @cfsmp3

Base: master ← Head: udp-fix

📝 Commits (1)

05513d7 Fixed bug with -udp address

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 src/lib_ccx/networking.c (+1 -6)

📄 Description

Last PR #547
Issue

I read something in the Internet about multicasting, unicasting, sockets in C, sample programs.
It's strange, but it seems that in the code simply mixed up the lines.
Tons of materials say that we should use INADDR_ANY in multicasts, and addr in unicasts, but the code is upside down, so if we give multicast address, it will works as unicast, and vice versa.
I fixed it and checked in Windows - works good, this part does not depend on the platform.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/549 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 12/17/2016 **Status:** ✅ Merged **Merged:** 12/22/2016 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `udp-fix` --- ### 📝 Commits (1) - [`05513d7`](https://github.com/CCExtractor/ccextractor/commit/05513d7279f45c3ef72cbf1a9327a5e7f3752d21) Fixed bug with -udp address ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/networking.c` (+1 -6) </details> ### 📄 Description Last PR #547 [Issue](https://github.com/CCExtractor/ccextractor/issues/378) I read something in the Internet about multicasting, unicasting, sockets in C, sample programs. It's strange, but it seems that in the code simply mixed up the lines. Tons of materials say that we should use `INADDR_ANY` in multicasts, and `addr` in unicasts, but the code is upside down, so if we give multicast address, it will works as unicast, and vice versa. I fixed it and checked in Windows - works good, this part does not depend on the platform. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:16:07 +00:00

claunia closed this issue

2026-01-29 17:16:08 +00:00

claunia referenced this issue

2026-01-29 17:20:33 +00:00

[PR #1383] [MERGED] remove default BOM from windows #2152

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1383