[PR #554] [MERGED] Fixed -stdin option in Windows #1388

Closed
opened 2026-01-29 17:16:09 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/554
Author: @Izaron
Created: 12/18/2016
Status: Merged
Merged: 12/22/2016
Merged by: @cfsmp3

Base: masterHead: pipes


📝 Commits (1)

  • ccd11d3 Fixed -stdin option in Windows

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/lib_ccx/params.c (+3 -1)

📄 Description

Issue
Using: "ccextractor -stdin [args] < file" or "type file | ccextractor -stdin [args]"
In Linux all was ok because on this platform 'stdin', 'stdout' and 'stderr' are binary by default.
What the difference between O_TEXT and O_BINARY in Windows: in Windows, the 'stdin' default (O_TEXT) behaviour is to treat byte 0x1a as an end of input and close the input, 0x0a (LF) as a new line and convert it to the two bytes 0x0d, 0x0a (CR+LF). There may be other transformations.

Also I have new issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/554 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 12/18/2016 **Status:** ✅ Merged **Merged:** 12/22/2016 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `pipes` --- ### 📝 Commits (1) - [`ccd11d3`](https://github.com/CCExtractor/ccextractor/commit/ccd11d38f8dca352e8306564a600435b2e8a71d5) Fixed -stdin option in Windows ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/params.c` (+3 -1) </details> ### 📄 Description [Issue](https://github.com/CCExtractor/ccextractor/issues/349) Using: "ccextractor -stdin [args] < file" or "type file | ccextractor -stdin [args]" In Linux all was ok because on this platform 'stdin', 'stdout' and 'stderr' are binary by default. What the difference between O_TEXT and O_BINARY in Windows: in Windows, the 'stdin' default (O_TEXT) behaviour is to treat byte 0x1a as an end of input and close the input, 0x0a (LF) as a new line and convert it to the two bytes 0x0d, 0x0a (CR+LF). There may be other transformations. Also I have new [issue](https://github.com/CCExtractor/ccextractor/issues/555). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:16:09 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1388