mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
Teletext page number dropped in -UCLA switch #143
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Liontooth on GitHub (May 19, 2016).
In the latest github version of CCExtractor the teletext page number is no longer listed in the third field:
The github version from mid-March shows the teletext page number and the string TLT:
What we actually want is the teletext number with no TLT string:
So the wrong part of the output was removed in a recent change. The teletext page number is useful information and we'd like to keep it.
Command:
Sample file:
On the other hand, the mid-March github version would typically fail to use Cyrillic for the very last line; this bug (not reported) has disappeared in the current version.
Cheers,
David
@Abhinav95 commented on GitHub (May 19, 2016):
Hi David.
I have introduced this undesirable change inadvertently while fixing another issue with the -ucla switch, and will try and fix this for you.
Could you confirm that you need only the teletext page number in the third field, while for other types of subtitles it should contain their mode (for instance ...|...|ISDB|... for ISDB subtitles)?
I will set it accordingly.
@bigharshrag commented on GitHub (May 19, 2016):
Hi David,
I would also like to add that I had noticed the bug in which Cyrillic would not be used for the last line and it was subsequently fixed (via #335).
@Abhinav95 commented on GitHub (May 19, 2016):
#360 should fix this
Sample output is now:-
20160519190355.280|20160519190358.360|888|-Может быть, вы забыли, я занимаюсь полковником Лыковым.
@Liontooth commented on GitHub (May 19, 2016):
@Abhinav95 -- great, that's exactly right. I'll test it.
@bigharshrag -- thank you for noticing!
@Liontooth commented on GitHub (May 20, 2016):
I can confirm #360 fixes this issue; please merge!