[PR #643] [MERGED] CEA-708 subtitle counter #1488

New Issue

claunia · 2026-01-29T17:16:44Z

claunia commented

2026-01-29 17:16:44 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/643
Author: @Izaron
Created: 1/13/2017
Status: ✅ Merged
Merged: 1/13/2017
Merged by: @cfsmp3

Base: master ← Head: 708-stuff

📝 Commits (2)

a727d2d Fixed hot bug with CEA-708 counter
aa0db3c Using correct CEA-708 subs counter

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_708_output.c (+5 -3)

📄 Description

Fixed bug with uncorrect srt numbers - histw-false.srt, histw-true.srt
We had a "disappearing subtitles", but in fact we had uncorrect numbering in tv->cc_count and decoder->tv->cc_count, because we increase these values before output function calling, but the output sometimes failed, because the window does not exist, so we can't use this value as counter. I used encoder->cea_708_counter as global correct counter for CEA-708.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/643 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 1/13/2017 **Status:** ✅ Merged **Merged:** 1/13/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `708-stuff` --- ### 📝 Commits (2) - [`a727d2d`](https://github.com/CCExtractor/ccextractor/commit/a727d2df264fb467c452bd76369cbfacf65f398f) Fixed hot bug with CEA-708 counter - [`aa0db3c`](https://github.com/CCExtractor/ccextractor/commit/aa0db3c528b5b2f4cde4241e7094c53db7e2c081) Using correct CEA-708 subs counter ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+5 -3) </details> ### 📄 Description Fixed bug with uncorrect srt numbers - [histw-false.srt](http://paste.ubuntu.com/23793294/), [histw-true.srt](http://paste.ubuntu.com/23793345/) We had a "disappearing subtitles", but in fact we had uncorrect numbering in tv->cc_count and decoder->tv->cc_count, because we increase these values before output function calling, but the output sometimes failed, because the window does not exist, so we can't use this value as counter. I used encoder->cea_708_counter as global correct counter for CEA-708. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:16:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1488