[PR #643] CEA-708 subtitle counter #1493

Open
opened 2026-01-29 17:16:45 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/643

State: closed
Merged: Yes


Fixed bug with uncorrect srt numbers - histw-false.srt, histw-true.srt
We had a "disappearing subtitles", but in fact we had uncorrect numbering in tv->cc_count and decoder->tv->cc_count, because we increase these values before output function calling, but the output sometimes failed, because the window does not exist, so we can't use this value as counter. I used encoder->cea_708_counter as global correct counter for CEA-708.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/643 **State:** closed **Merged:** Yes --- Fixed bug with uncorrect srt numbers - [histw-false.srt](http://paste.ubuntu.com/23793294/), [histw-true.srt](http://paste.ubuntu.com/23793345/) We had a "disappearing subtitles", but in fact we had uncorrect numbering in tv->cc_count and decoder->tv->cc_count, because we increase these values before output function calling, but the output sometimes failed, because the window does not exist, so we can't use this value as counter. I used encoder->cea_708_counter as global correct counter for CEA-708.
claunia added the pull-request label 2026-01-29 17:16:45 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1493