[PR #686] [MERGED] Webvtt new fix #1517

Open
opened 2026-01-29 17:16:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/686
Author: @barun511
Created: 2/14/2017
Status: Merged
Merged: 2/15/2017
Merged by: @cfsmp3

Base: masterHead: webvtt_new_fix


📝 Commits (3)

  • 7c2483d Fix webvtt formatting
  • 73f3c83 Add -lf support | make line terminator consistent
  • e919f1b Add comments, change array iteration

📊 Changes

2 files changed (+31 additions, -11 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_common.c (+22 -10)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+9 -1)

📄 Description

Fixes #683 in a more consistent manner (no mixing of CRLF and LF), and obeys the -lf parameter.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/686 **Author:** [@barun511](https://github.com/barun511) **Created:** 2/14/2017 **Status:** ✅ Merged **Merged:** 2/15/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `webvtt_new_fix` --- ### 📝 Commits (3) - [`7c2483d`](https://github.com/CCExtractor/ccextractor/commit/7c2483d73e9e97981568732d521601d6a4711eeb) Fix webvtt formatting - [`73f3c83`](https://github.com/CCExtractor/ccextractor/commit/73f3c83940e9f4180fa1f75e8672176841a9b029) Add -lf support | make line terminator consistent - [`e919f1b`](https://github.com/CCExtractor/ccextractor/commit/e919f1b9f5e092370044eaf64bfdd6704705a325) Add comments, change array iteration ### 📊 Changes **2 files changed** (+31 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_common.c` (+22 -10) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+9 -1) </details> ### 📄 Description Fixes #683 in a more consistent manner (no mixing of CRLF and LF), and obeys the -lf parameter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:16:53 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1517