[PR #714] [MERGED] [IMPROVEMENT] Cleaning and replacing redundant code with already existing functions. #1538

New Issue

claunia · 2026-01-29T17:17:02Z

claunia commented

2026-01-29 17:17:02 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/714
Author: @saurabhshri
Created: 3/11/2017
Status: ✅ Merged
Merged: 3/14/2017
Merged by: @cfsmp3

Base: master ← Head: Cleaning

📝 Commits (2)

4bcc79f Use already available functions.
7b4c3bb Removed depricated function.

📊 Changes

3 files changed (+8 additions, -51 deletions)

View changed files

📝 src/lib_ccx/lib_ccx.h (+0 -1)
📝 src/lib_ccx/matroska.c (+8 -40)
📝 src/lib_ccx/utility.c (+0 -10)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This is quick PR in which :

Removed code with redundant functionality.

extracting filename without extension
generating timestamp for srt format from milliseconds

Checked for all samples from #705 .

Also removed a deprecated function which is no longer anywhere used (timestamp_to_smptetttime).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/714 **Author:** [@saurabhshri](https://github.com/saurabhshri) **Created:** 3/11/2017 **Status:** ✅ Merged **Merged:** 3/14/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `Cleaning` --- ### 📝 Commits (2) - [`4bcc79f`](https://github.com/CCExtractor/ccextractor/commit/4bcc79fdb788c835403cf5232a45052b1dee31b7) Use already available functions. - [`7b4c3bb`](https://github.com/CCExtractor/ccextractor/commit/7b4c3bb26db9abfbeb3922e0677d3c39751daccb) Removed depricated function. ### 📊 Changes **3 files changed** (+8 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/lib_ccx.h` (+0 -1) 📝 `src/lib_ccx/matroska.c` (+8 -40) 📝 `src/lib_ccx/utility.c` (+0 -10) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This is quick PR in which : Removed code with redundant functionality. - extracting filename without extension - generating timestamp for srt format from milliseconds Checked for all samples from #705 . Also removed a deprecated function which is no longer anywhere used (`timestamp_to_smptetttime`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:02 +00:00

claunia referenced this issue

2026-01-29 17:21:10 +00:00

[PR #1538] [MERGED] [FIX] Repeated values for enums #2255

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1538