[PR #714] [IMPROVEMENT] Cleaning and replacing redundant code with already existing functions. #1542

New Issue

claunia · 2026-01-29T17:17:03Z

claunia commented

2026-01-29 17:17:03 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/714

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This is quick PR in which :

Removed code with redundant functionality.

extracting filename without extension
generating timestamp for srt format from milliseconds

Checked for all samples from #705 .

Also removed a deprecated function which is no longer anywhere used (timestamp_to_smptetttime).

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/714 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This is quick PR in which : Removed code with redundant functionality. - extracting filename without extension - generating timestamp for srt format from milliseconds Checked for all samples from #705 . Also removed a deprecated function which is no longer anywhere used (`timestamp_to_smptetttime`).

claunia added the pull-request label 2026-01-29 17:17:03 +00:00

claunia referenced this issue

2026-01-29 17:23:10 +00:00

[PR #1859] [MERGED] fix(mcc): Add MCC output support for raw caption files #2628

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1542