[PR #721] [MERGED] **[FIX]** Fixes issue #705 #1545

New Issue

claunia · 2026-01-29T17:17:06Z

claunia commented

2026-01-29 17:17:06 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/721
Author: @Diptanshu8
Created: 3/15/2017
Status: ✅ Merged
Merged: 3/16/2017
Merged by: @cfsmp3

Base: master ← Head: matroska

📝 Commits (10+)

7feb705 Rebasing
d2d055d Done with removal of MATROSKA_MAX_TRACKS
d08cad3 Rebasing
6f5b2aa Changes made to avoid breakline/newline at the beginning of sentence.
2c7bfef ASS/SSA support added for avoiding newline chars at the beginning of sentence.
f944c93 yet to cover ass/ssa subtitiles' newline
9bbab6b ASS/SSA newline character covered
712e44e Checking the concatenated videos for subtitle errors and resolved
75a010f Static option eng for only english subtitles has been set
3b0031c MKVlang support for a single language has been added.

📊 Changes

5 files changed (+115 additions, -29 deletions)

View changed files

📝 src/lib_ccx/ccx_common_option.c (+1 -0)
📝 src/lib_ccx/ccx_common_option.h (+2 -1)
📝 src/lib_ccx/matroska.c (+35 -18)
📝 src/lib_ccx/matroska.h (+5 -7)
📝 src/lib_ccx/params.c (+72 -3)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active #contributor to CCExtractor.

{pull request content here}
fixes points 1,2,4 and additional -mklang option mentioned in #705

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/721 **Author:** [@Diptanshu8](https://github.com/Diptanshu8) **Created:** 3/15/2017 **Status:** ✅ Merged **Merged:** 3/16/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `matroska` --- ### 📝 Commits (10+) - [`7feb705`](https://github.com/CCExtractor/ccextractor/commit/7feb705d73a3e78bf9e75a6bd939513ea70e1964) Rebasing - [`d2d055d`](https://github.com/CCExtractor/ccextractor/commit/d2d055dd37c4587300a6f034b14beec9a96dfa14) Done with removal of MATROSKA_MAX_TRACKS - [`d08cad3`](https://github.com/CCExtractor/ccextractor/commit/d08cad3642d38db0e3d638e2413175a111f69c31) Rebasing - [`6f5b2aa`](https://github.com/CCExtractor/ccextractor/commit/6f5b2aa360ee72e7affaf8de57bf22d732df9fe7) Changes made to avoid breakline/newline at the beginning of sentence. - [`2c7bfef`](https://github.com/CCExtractor/ccextractor/commit/2c7bfef0f0eef6443b741f86196c2b0315443a8e) ASS/SSA support added for avoiding newline chars at the beginning of sentence. - [`f944c93`](https://github.com/CCExtractor/ccextractor/commit/f944c93faa473cea3eca8a8b55bcbfa2dda7b251) yet to cover ass/ssa subtitiles' newline - [`9bbab6b`](https://github.com/CCExtractor/ccextractor/commit/9bbab6b59545a247257283fd26e481da3f8edc1c) ASS/SSA newline character covered - [`712e44e`](https://github.com/CCExtractor/ccextractor/commit/712e44e26cc09704135ed6a7d20328f611ec5c15) Checking the concatenated videos for subtitle errors and resolved - [`75a010f`](https://github.com/CCExtractor/ccextractor/commit/75a010fe77c86af1b4d4dd4854955a16c366acdb) Static option _eng_ for only english subtitles has been set - [`3b0031c`](https://github.com/CCExtractor/ccextractor/commit/3b0031c25131bd76b21a218a3dd3ba5cfe4236bb) MKVlang support for a single language has been added. ### 📊 Changes **5 files changed** (+115 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_option.c` (+1 -0) 📝 `src/lib_ccx/ccx_common_option.h` (+2 -1) 📝 `src/lib_ccx/matroska.c` (+35 -18) 📝 `src/lib_ccx/matroska.h` (+5 -7) 📝 `src/lib_ccx/params.c` (+72 -3) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active #contributor to CCExtractor. --- {pull request content here} fixes points 1,2,4 and additional `-mklang` option mentioned in #705 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:06 +00:00

claunia referenced this issue

2026-01-29 17:21:12 +00:00

[PR #1545] [CLOSED] [WIP] Ocr rust port #2261

claunia referenced this issue

2026-01-29 17:21:12 +00:00

[PR #1545] [WIP] Ocr rust port #2263

Sign in to join this conversation.