[PR #725] [MERGED] Issue 699 solved #1548

Closed
opened 2026-01-29 17:17:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/725
Author: @Amey-Jain
Created: 3/20/2017
Status: Merged
Merged: 4/11/2017
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (4)

  • d2bea38 In ref. to issue 699. 20 ms timing mis-match.
  • 094a8f2 Issue 699 solved.
  • 1b3598b Timing mis-match corrected.
  • 1513b7c Timing for sample #70 corrected.

📊 Changes

3 files changed (+15 additions, -10 deletions)

View changed files

📝 src/lib_ccx/general_loop.c (+5 -3)
📝 src/lib_ccx/lib_ccx.c (+1 -1)
📝 src/lib_ccx/telxcc.c (+9 -6)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • [*] I have read and understood the contributors guide.
  • [*] I have checked that another pull request for this purpose does not exist.
  • [*] I have considered, and confirmed that this submission will be valuable to others.
  • [*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [*] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.
  • I have never used CCExtractor.
  • [*] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Due to blank returns from various conditions in process_telx_packet() (even after page_buffer containing data), data was not being written to output file. Also after file buffer is completed, data needs to be dumped to file.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/725 **Author:** [@Amey-Jain](https://github.com/Amey-Jain) **Created:** 3/20/2017 **Status:** ✅ Merged **Merged:** 4/11/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`d2bea38`](https://github.com/CCExtractor/ccextractor/commit/d2bea3802e14994297b6d28e3093d1a667de2ef3) In ref. to issue 699. 20 ms timing mis-match. - [`094a8f2`](https://github.com/CCExtractor/ccextractor/commit/094a8f295a91e919ab58573cfb5e3afacd91e06c) Issue 699 solved. - [`1b3598b`](https://github.com/CCExtractor/ccextractor/commit/1b3598b2fe0cf4fca860f572900ec2d386d59d6b) Timing mis-match corrected. - [`1513b7c`](https://github.com/CCExtractor/ccextractor/commit/1513b7c42f2fe08e64a9d537c46889b81d852f8d) Timing for sample #70 corrected. ### 📊 Changes **3 files changed** (+15 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/general_loop.c` (+5 -3) 📝 `src/lib_ccx/lib_ccx.c` (+1 -1) 📝 `src/lib_ccx/telxcc.c` (+9 -6) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [*] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [*] I have checked that another pull request for this purpose does not exist. - [*] I have considered, and confirmed that this submission will be valuable to others. - [*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [*] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have used CCExtractor just a couple of times. - [ ] I have never used CCExtractor. - [*] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Due to blank returns from various conditions in process_telx_packet() (even after page_buffer containing data), data was not being written to output file. Also after file buffer is completed, data needs to be dumped to file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:17:06 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1548