[PR #760] [CLOSED] **[IMPROVEMENT]** Extracted captions alongwith timing data available in python for further processing. #1575

New Issue

claunia · 2026-01-29T17:17:17Z

claunia commented

2026-01-29 17:17:17 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/760
Author: @Diptanshu8
Created: 7/24/2017
Status: ❌ Closed

Base: master ← Head: second_phase_evaluation

📝 Commits (10+)

aabeed3 added python_extract to encoders_srt and the captions are being
d9add14 Checking if the alternative to asprintf generate proper srts
a39328c CC captions accessible via python script
7665d1f Removing python caption code from __wrap_write function
f346676 removing old cc_to_python functions
ac95e52 Removing python_subs structure and all the changes done for that struct
ccfcd47 Removing filename functions from ccextractor.*
af0e52d Renaming make_message to time_wrapper
3c913a2 Applying to python_extract codebase: SSA format
605c094 Added python_extract_time_based and done validation for ssa

📊 Changes

17 files changed (+1036 additions, -264 deletions)

View changed files

📝 api/api_testing.py (+23 -1)
📝 api/build_api (+2 -1)
📝 api/ccextractor.i (+27 -0)
📝 api/ccextractor.py (+128 -35)
📝 api/ccextractor_wrap.c (+585 -168)
➕ api/extractors/extractor.c (+82 -0)
➕ api/extractors/extractor.h (+9 -0)
📝 api/wrappers/wrapper.h (+1 -1)
📝 linux/build (+4 -2)
📝 src/ccextractor.c (+133 -38)
📝 src/ccextractor.h (+26 -14)
📝 src/lib_ccx/ccx_encoders_sami.c (+2 -0)
📝 src/lib_ccx/ccx_encoders_smptett.c (+2 -2)
📝 src/lib_ccx/ccx_encoders_srt.c (+1 -0)
📝 src/lib_ccx/ccx_encoders_ssa.c (+9 -1)
📝 src/lib_ccx/ccx_encoders_transcript.c (+1 -0)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+1 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

[*] I have read and understood the contributors guide.
[*] I have checked that another pull request for this purpose does not exist.
[*] I have considered, and confirmed that this submission will be valuable to others.
[*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[*] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
[*] I am an active contributor to CCExtractor.

This PR mainly focuses on the following points:

Replacing the older container for accessing extracted captions in python with timings
Addded api/extractors/* code for extractors which play the role of extracting captions and their timings for python processing.
Added a function show_extracted_captions_with_timings in the main code for checking if the captions along with their timings are extracted or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/760 **Author:** [@Diptanshu8](https://github.com/Diptanshu8) **Created:** 7/24/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `second_phase_evaluation` --- ### 📝 Commits (10+) - [`aabeed3`](https://github.com/CCExtractor/ccextractor/commit/aabeed37c99b7ce7ca81ce8931b6f5e1a052f8b9) added python_extract to encoders_srt and the captions are being - [`d9add14`](https://github.com/CCExtractor/ccextractor/commit/d9add1454f29c4be9bc69f5c7e153642f9af8d87) Checking if the alternative to asprintf generate proper srts - [`a39328c`](https://github.com/CCExtractor/ccextractor/commit/a39328c964c9e65bc377081625fa49134f0f3d6a) CC captions accessible via python script - [`7665d1f`](https://github.com/CCExtractor/ccextractor/commit/7665d1fc65b9f747f726e2996480bbcdbaea06d4) Removing python caption code from __wrap_write function - [`f346676`](https://github.com/CCExtractor/ccextractor/commit/f346676a62855068ef9c044310f6dfb37b14cbc3) removing old cc_to_python functions - [`ac95e52`](https://github.com/CCExtractor/ccextractor/commit/ac95e526d69591ea09ec44a392ebb7be5f95cbc3) Removing python_subs structure and all the changes done for that struct - [`ccfcd47`](https://github.com/CCExtractor/ccextractor/commit/ccfcd47bb67cc738c0ca18389484e8c454087f17) Removing filename functions from ccextractor.* - [`af0e52d`](https://github.com/CCExtractor/ccextractor/commit/af0e52d3b199f04168becedcc89e0396a7b9c668) Renaming make_message to time_wrapper - [`3c913a2`](https://github.com/CCExtractor/ccextractor/commit/3c913a29c80a325e4a6822eebc783f2e9e3e7b75) Applying to python_extract codebase: SSA format - [`605c094`](https://github.com/CCExtractor/ccextractor/commit/605c094af1c2492326405f38dab6c19f38bcf5e8) Added python_extract_time_based and done validation for ssa ### 📊 Changes **17 files changed** (+1036 additions, -264 deletions) <details> <summary>View changed files</summary> 📝 `api/api_testing.py` (+23 -1) 📝 `api/build_api` (+2 -1) 📝 `api/ccextractor.i` (+27 -0) 📝 `api/ccextractor.py` (+128 -35) 📝 `api/ccextractor_wrap.c` (+585 -168) ➕ `api/extractors/extractor.c` (+82 -0) ➕ `api/extractors/extractor.h` (+9 -0) 📝 `api/wrappers/wrapper.h` (+1 -1) 📝 `linux/build` (+4 -2) 📝 `src/ccextractor.c` (+133 -38) 📝 `src/ccextractor.h` (+26 -14) 📝 `src/lib_ccx/ccx_encoders_sami.c` (+2 -0) 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+2 -2) 📝 `src/lib_ccx/ccx_encoders_srt.c` (+1 -0) 📝 `src/lib_ccx/ccx_encoders_ssa.c` (+9 -1) 📝 `src/lib_ccx/ccx_encoders_transcript.c` (+1 -0) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+1 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [*] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [*] I have checked that another pull request for this purpose does not exist. - [*] I have considered, and confirmed that this submission will be valuable to others. - [*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [*] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [*] I am an active contributor to CCExtractor. --- This PR mainly focuses on the following points: - Replacing the older container for accessing extracted captions in python with timings - Addded api/extractors/* code for extractors which play the role of extracting captions and their timings for python processing. - Added a function `show_extracted_captions_with_timings` in the main code for checking if the captions along with their timings are extracted or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:17 +00:00

claunia closed this issue

2026-01-29 17:17:17 +00:00

claunia referenced this issue

2026-01-29 17:22:47 +00:00

[PR #1817] [MERGED] fix(rust): Add bounds checks to prevent panic on malformed CEA-708 data #2561

claunia referenced this issue

2026-01-29 17:22:48 +00:00

[PR #1817] fix(rust): Add bounds checks to prevent panic on malformed CEA-708 data #2565

Sign in to join this conversation.