[PR #771] [MERGED] Cleaning up the codebase and additional changes in Python SRT generator. #1585

New Issue

claunia · 2026-01-29T17:17:22Z

claunia commented

2026-01-29 17:17:22 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/771
Author: @Diptanshu8
Created: 8/23/2017
Status: ✅ Merged
Merged: 8/25/2017
Merged by: @cfsmp3

Base: master ← Head: refactoring

📝 Commits (10+)

4ab7599 Removed all extractors except the grid extractor.
2da0bad Removed unnecessary array appening statements in python_grid_extractor.
bd3b882 Added switch in g608 grid extractor.
8734603 Deleted comments from wrappers.
f89ba0d Refactored code in ccextractor.c and .h files.
9e1123b Removed calls to extractor from all the encoders.
6688897 Removed a comment from wrapper.c.
cea9982 Added calls to free the char* which is malloced by asprintf in
d5e25fa Sample testing correctly for italics tag.
e58d132 Added support for handling font and italics in Python SRT generator.

📊 Changes

24 files changed (+382 additions, -1470 deletions)

View changed files

📝 api/api_support.py (+19 -30)
📝 api/api_testing.py (+2 -39)
📝 api/ccextractor.py (+4 -84)
📝 api/ccextractor_wrap.c (+84 -942)
📝 api/extractors/extractor.c (+61 -133)
📝 api/extractors/extractor.h (+2 -5)
📝 api/python_srt_generator.py (+113 -39)
➕ api/recursive_tester.py (+25 -0)
📝 api/wrappers/wrapper.c (+0 -10)
📝 api/wrappers/wrapper.h (+0 -1)
📝 linux/Makefile.am (+6 -1)
📝 linux/build (+1 -3)
📝 src/ccextractor.c (+45 -110)
📝 src/ccextractor.h (+3 -25)
📝 src/lib_ccx/ccx_encoders_common.c (+3 -2)
📝 src/lib_ccx/ccx_encoders_g608.c (+7 -23)
📝 src/lib_ccx/ccx_encoders_python.c (+5 -5)
📝 src/lib_ccx/ccx_encoders_sami.c (+0 -2)
📝 src/lib_ccx/ccx_encoders_smptett.c (+0 -3)
📝 src/lib_ccx/ccx_encoders_srt.c (+0 -1)

...and 4 more files

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

[*] I have read and understood the contributors guide.
[*] I have checked that another pull request for this purpose does not exist.
[*] I have considered, and confirmed that this submission will be valuable to others.
[*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[*] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
[*] I am an active contributor to CCExtractor.

This is majorly a Cleanup PR for cleaning up the codebase.
A feature to compare the font<->text grids and color<->text grids in Python for generating the output srt file has been added.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/771 **Author:** [@Diptanshu8](https://github.com/Diptanshu8) **Created:** 8/23/2017 **Status:** ✅ Merged **Merged:** 8/25/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `refactoring` --- ### 📝 Commits (10+) - [`4ab7599`](https://github.com/CCExtractor/ccextractor/commit/4ab75998829f2f91bb856436df2d876ee7e49feb) Removed all extractors except the grid extractor. - [`2da0bad`](https://github.com/CCExtractor/ccextractor/commit/2da0bad28ae75d9f4dd0c10a285c70add74844d5) Removed unnecessary array appening statements in python_grid_extractor. - [`bd3b882`](https://github.com/CCExtractor/ccextractor/commit/bd3b882094935328295e6d1abccd36dff8c178e9) Added switch in g608 grid extractor. - [`8734603`](https://github.com/CCExtractor/ccextractor/commit/8734603d1dcdda683879e8716209576aa751588e) Deleted comments from wrappers. - [`f89ba0d`](https://github.com/CCExtractor/ccextractor/commit/f89ba0d4cf502c651e8b5373b284fb1451c11892) Refactored code in ccextractor.c and .h files. - [`9e1123b`](https://github.com/CCExtractor/ccextractor/commit/9e1123bf5c087312b37789949a9f81a34875efca) Removed calls to extractor from all the encoders. - [`6688897`](https://github.com/CCExtractor/ccextractor/commit/66888970645fd596cd51b3c718885047ca107ca4) Removed a comment from wrapper.c. - [`cea9982`](https://github.com/CCExtractor/ccextractor/commit/cea99829b6de1c08869f00d63b833061ff693de3) Added calls to free the char* which is malloced by asprintf in - [`d5e25fa`](https://github.com/CCExtractor/ccextractor/commit/d5e25fadcce558fe57ff535765073d2c2eef8fbd) Sample testing correctly for italics tag. - [`e58d132`](https://github.com/CCExtractor/ccextractor/commit/e58d132e22295cf416386c7953d0877afffdf683) Added support for handling font and italics in Python SRT generator. ### 📊 Changes **24 files changed** (+382 additions, -1470 deletions) <details> <summary>View changed files</summary> 📝 `api/api_support.py` (+19 -30) 📝 `api/api_testing.py` (+2 -39) 📝 `api/ccextractor.py` (+4 -84) 📝 `api/ccextractor_wrap.c` (+84 -942) 📝 `api/extractors/extractor.c` (+61 -133) 📝 `api/extractors/extractor.h` (+2 -5) 📝 `api/python_srt_generator.py` (+113 -39) ➕ `api/recursive_tester.py` (+25 -0) 📝 `api/wrappers/wrapper.c` (+0 -10) 📝 `api/wrappers/wrapper.h` (+0 -1) 📝 `linux/Makefile.am` (+6 -1) 📝 `linux/build` (+1 -3) 📝 `src/ccextractor.c` (+45 -110) 📝 `src/ccextractor.h` (+3 -25) 📝 `src/lib_ccx/ccx_encoders_common.c` (+3 -2) 📝 `src/lib_ccx/ccx_encoders_g608.c` (+7 -23) 📝 `src/lib_ccx/ccx_encoders_python.c` (+5 -5) 📝 `src/lib_ccx/ccx_encoders_sami.c` (+0 -2) 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+0 -3) 📝 `src/lib_ccx/ccx_encoders_srt.c` (+0 -1) _...and 4 more files_ </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [*] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [*] I have checked that another pull request for this purpose does not exist. - [*] I have considered, and confirmed that this submission will be valuable to others. - [*] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [*] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [*] I am an active contributor to CCExtractor. --- This is majorly a Cleanup PR for cleaning up the codebase. A feature to compare the font<->text grids and color<->text grids in Python for generating the output srt file has been added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1585