mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-15 05:26:07 +00:00
TS file that doesn't even generate an output file #159
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cfsmp3 on GitHub (Jun 8, 2016).
Originally assigned to: @canihavesomecoffee, @anshul1912, @rkuchumov, @okisseloff, @bigharshrag on GitHub.
The file friends_tbs.ts, which was just shared in slack and will be uploaded to the global repository, doesn't generate any output. I mean, it doesn't even generate a .srt file using this:
/home/captions/ccextractorgit/ccextractor/linux/ccextractor -srt friends_tbs.ts
The output is
Opening file: friends_tbs.ts
File seems to be a transport stream, enabling TS mode
Analyzing data in general mode
Done, processing time = 0 seconds
This is beta software. Report issues to carlos at ccextractor org...
It processes it instantly and produces no output file.
VLC plays it correctly.
I haven't analyzed it myself yet because there's a bunch of other things I'm doing right now but this probably evidences a really weird bug we need to look into asap.
@cfsmp3 commented on GitHub (Jun 8, 2016):
Assigned to all veterans
@canihavesomecoffee commented on GitHub (Jun 8, 2016):
Ran it with -parsedebug
Prints "Packet (pid 5355, 5357, 5358, 5389) skipped - no stream with captions identified yet" until it runs out of file to process.
Interestingly VLC seems to be one of the only ones that can display the captions...
@cfsmp3 commented on GitHub (Jun 9, 2016):
Pasting my own rant from slack:
So what I'm seeing is that we aren't parsing the PMT and we are leaving the function here:
if (table_id == 0xC0)
{
/*
* Acc to System Information for Satellite Distribution
* of Digital Television for Cable and MMDS (ANSI/SCTE 57 2003 )
* PROGRAM INFORMATION Table found in PMT
*/
dbg_print(CCX_DMT_PARSE, "PMT: PROGRAM INFORMATION Table need implementation");
return 0;
}
[a bit later]
So good news is that the regular PMT comes after that section
so I got it to work by cheating that removing that section from the buffer
But bad news is that we should be processing the PMT without making assumptions about sections in the PMT... for example now I'm just deleting that from the buffer (not skipping it, because the parsing code assumes that the usual table starts at the beginning of the buffer)
but we should have a loop that checks the table_id, if it's 0xC0 skips it (or better, parse it, even though we don't need it for now just to get the captions), if it's 2 parses it as usual..... and then processes the next section without assuming order of sections, as apparently they may come in any order
@cfsmp3 commented on GitHub (Nov 29, 2016):
Direct link:
https://drive.google.com/open?id=0B_61ywKPmI0TRm9iM2pBbDZPOWc
@ghost commented on GitHub (Jan 7, 2017):
Confirming that this is fixed as of 0.84.
friends_tbs.zip