[PR #786] [MERGED] [IMPROVEMENT] function header in "get_more_data" functions were standarlized. #1595

New Issue

claunia · 2026-01-29T17:17:27Z

claunia commented

2026-01-29 17:17:27 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/786
Author: @iha
Created: 10/4/2017
Status: ✅ Merged
Merged: 10/13/2017
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (4)

300228b function header in "get_more_data" functions were standarlized.
4e038eb Unnecessary stream_mode check inside the while loop was removed.
9a1d6a6 terminate_asap if condition was moved to while condition.
a6db7e2 Unnecessary condition was removed.

📊 Changes

7 files changed (+42 additions, -42 deletions)

View changed files

📝 src/lib_ccx/ccx_gxf.c (+2 -2)
📝 src/lib_ccx/ccx_gxf.h (+2 -1)
📝 src/lib_ccx/ffmpeg_intgr.c (+2 -2)
📝 src/lib_ccx/ffmpeg_intgr.h (+1 -1)
📝 src/lib_ccx/general_loop.c (+32 -33)
📝 src/lib_ccx/lib_ccx.h (+1 -1)
📝 src/lib_ccx/ts_functions.c (+2 -2)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This PR makes the CCExtractor more standardized, avoid future bugs and allow us to remove the unnecessary switch (stream_mode) inside the while loop in general_loop().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/786 **Author:** [@iha](https://github.com/iha) **Created:** 10/4/2017 **Status:** ✅ Merged **Merged:** 10/13/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`300228b`](https://github.com/CCExtractor/ccextractor/commit/300228b80a400804164a8dd5bab91ffacf74d2b6) function header in "get_more_data" functions were standarlized. - [`4e038eb`](https://github.com/CCExtractor/ccextractor/commit/4e038eb6a2b7f65d7c6d6b6e17847f75135d71cb) Unnecessary stream_mode check inside the while loop was removed. - [`9a1d6a6`](https://github.com/CCExtractor/ccextractor/commit/9a1d6a69022fb8b1ab4adfeac7f13241b2e1940a) terminate_asap if condition was moved to while condition. - [`a6db7e2`](https://github.com/CCExtractor/ccextractor/commit/a6db7e29a7e2b7d2cb6521d72db077c0013afe31) Unnecessary condition was removed. ### 📊 Changes **7 files changed** (+42 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_gxf.c` (+2 -2) 📝 `src/lib_ccx/ccx_gxf.h` (+2 -1) 📝 `src/lib_ccx/ffmpeg_intgr.c` (+2 -2) 📝 `src/lib_ccx/ffmpeg_intgr.h` (+1 -1) 📝 `src/lib_ccx/general_loop.c` (+32 -33) 📝 `src/lib_ccx/lib_ccx.h` (+1 -1) 📝 `src/lib_ccx/ts_functions.c` (+2 -2) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR makes the CCExtractor more standardized, avoid future bugs and allow us to remove the unnecessary *switch (stream_mode)* inside the *while* loop in general_loop(). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:27 +00:00

claunia referenced this issue

2026-01-29 17:21:25 +00:00

[PR #1595] [MERGED] [FEATURE] Add SCC support to CEA-708 decoder #2307

claunia referenced this issue

2026-01-29 17:21:26 +00:00

[PR #1595] [FEATURE] Add SCC support to CEA-708 decoder #2310

Sign in to join this conversation.