[PR #844] [MERGED] [Fix] Fix DVB bug (Multiple-line subtitle; Missing last line) #1668

New Issue

claunia · 2026-01-29T17:17:51Z

claunia commented

2026-01-29 17:17:51 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/844
Author: @harrynull
Created: 12/25/2017
Status: ✅ Merged
Merged: 12/26/2017
Merged by: @cfsmp3

Base: master ← Head: patch-dvb-sub

📝 Commits (3)

de02873 multiple line & trying to fix the missing last line
040668e Fix format; move code into loop
e8349c7 Revert some format changes

📊 Changes

3 files changed (+173 additions, -74 deletions)

View changed files

📝 src/lib_ccx/dvb_subtitle_decoder.c (+8 -5)
📝 src/lib_ccx/general_loop.c (+76 -58)
📝 src/lib_ccx/ocr.c (+89 -11)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Fix #840

Fix the bug that only the first line of text from each caption is shown.
Fix the bug that the last caption is missing.
The shifting time isn't really a problem because it is indeed shifting a little bit in the video and the conversion from fps->1000 will also cause some precision problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/844 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 12/25/2017 **Status:** ✅ Merged **Merged:** 12/26/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `patch-dvb-sub` --- ### 📝 Commits (3) - [`de02873`](https://github.com/CCExtractor/ccextractor/commit/de028733f11f2809ad1e195dd97da988c5582907) multiple line & trying to fix the missing last line - [`040668e`](https://github.com/CCExtractor/ccextractor/commit/040668e97da7d7d237d87b09d1bbc38cf2ba0c42) Fix format; move code into loop - [`e8349c7`](https://github.com/CCExtractor/ccextractor/commit/e8349c7b17e0773fed941335727b9053b202c16e) Revert some format changes ### 📊 Changes **3 files changed** (+173 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/dvb_subtitle_decoder.c` (+8 -5) 📝 `src/lib_ccx/general_loop.c` (+76 -58) 📝 `src/lib_ccx/ocr.c` (+89 -11) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Fix #840 - Fix the bug that only the first line of text from each caption is shown. - Fix the bug that the last caption is missing. - The shifting time isn't really a problem because it is indeed shifting a little bit in the video and the conversion from fps->1000 will also cause some precision problems. ![1](https://user-images.githubusercontent.com/7413706/34340034-7e8e7b9c-e9b7-11e7-911c-7ebd073f7927.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:51 +00:00

claunia referenced this issue

2026-01-29 17:21:49 +00:00

[PR #1668] [MERGED] [FIX] Replaced deprecated module `std::intrinsics` with `std::ptr` #2375

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1668