[PR #844] [Fix] Fix DVB bug (Multiple-line subtitle; Missing last line) #1670

New Issue

claunia · 2026-01-29T17:17:52Z

claunia commented

2026-01-29 17:17:52 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/844

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Fix #840

Fix the bug that only the first line of text from each caption is shown.
Fix the bug that the last caption is missing.
The shifting time isn't really a problem because it is indeed shifting a little bit in the video and the conversion from fps->1000 will also cause some precision problems.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/844 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Fix #840 - Fix the bug that only the first line of text from each caption is shown. - Fix the bug that the last caption is missing. - The shifting time isn't really a problem because it is indeed shifting a little bit in the video and the conversion from fps->1000 will also cause some precision problems. ![1](https://user-images.githubusercontent.com/7413706/34340034-7e8e7b9c-e9b7-11e7-911c-7ebd073f7927.png)

claunia added the pull-request label 2026-01-29 17:17:52 +00:00

claunia closed this issue

2026-01-29 17:17:53 +00:00

claunia referenced this issue

2026-01-29 17:21:50 +00:00

[PR #1670] [MERGED] [FIX] Fix vulnerability in url crate #2379

claunia referenced this issue

2026-01-29 17:21:51 +00:00

[PR #1670] [FIX] Fix vulnerability in url crate #2383

Sign in to join this conversation.