[PR #894] [MERGED] [IMPROVEMENT] Upgrade libgpac based on Hori75's branch #1734

Closed
opened 2026-01-29 17:18:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/894
Author: @harrynull
Created: 1/10/2018
Status: Merged
Merged: 1/11/2018
Merged by: @cfsmp3

Base: masterHead: libgpac


📝 Commits (10+)

📊 Changes

60 files changed (+30940 additions, -21459 deletions)

View changed files

📝 gsoc/skrill/first_phase_evaluation_script (+0 -0)
📝 linux/Makefile.am (+6 -2)
📝 linux/build (+1 -1)
📝 linux/build_hardsubx (+1 -1)
📝 linux/builddebug (+1 -1)
📝 mac/Makefile.am (+6 -2)
📝 mac/build.command (+1 -1)
📝 src/CMakeLists.txt (+1 -1)
📝 src/gpacmp4/av_parsers.c (+1063 -832)
📝 src/gpacmp4/avc_ext.c (+435 -321)
📝 src/gpacmp4/avilib.c (+766 -776)
📝 src/gpacmp4/box_code_3gpp.c (+155 -305)
📝 src/gpacmp4/box_code_adobe.c (+87 -113)
📝 src/gpacmp4/box_code_apple.c (+62 -80)
📝 src/gpacmp4/box_code_base.c (+3300 -1780)
📝 src/gpacmp4/box_code_drm.c (+283 -373)
📝 src/gpacmp4/box_code_meta.c (+124 -174)
src/gpacmp4/box_dump.c (+5180 -0)
📝 src/gpacmp4/box_funcs.c (+1220 -2663)
src/gpacmp4/color.c (+2936 -0)

...and 40 more files

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Upgrade libgpac to 0.7.0 0.7.1.

The pr fixes the failing sample, based on @Hori75 's pr #871 .

List of changes I have made: (For future references when upgrading it...)

  • Change box_funcs.c: comment out some of the lines to avoid introduce too many files. See dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d
  • In gpac/configuration.h, comment out all #define GPAC_MEMORY_TRACKING (there are currently two of it) and #else #error "Unknown target platform used with static configuration file" (To avoid compilation errors in Linux)
  • In gpac/isomedia.h, add more constants. See dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d
  • Make gpac/revision.h yourself; update the version.
  • In /gpac/setup.h, change functions like void* gf_malloc(size_t size); to #define gf_malloc malloc (to avoid introducing alloc.c)
  • In isom_write.c, remove line #include <gpac/iso639.h>

Please don't merge until the CI platforms run it


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/894 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 1/10/2018 **Status:** ✅ Merged **Merged:** 1/11/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `libgpac` --- ### 📝 Commits (10+) - [`bbe2f33`](https://github.com/CCExtractor/ccextractor/commit/bbe2f333997fe8d90f3851ba6dcdbd5d58e3ecf0) The real changes (This gonna be messy) - [`d96b8e0`](https://github.com/CCExtractor/ccextractor/commit/d96b8e0e83832387b03fc218da01eeb5714b3363) Modify makefile.am for linux and mac - [`a531779`](https://github.com/CCExtractor/ccextractor/commit/a5317799e806e0a9774ab1f38ef39c1b1927738d) Configuring the vs project solution - [`7a4f4a8`](https://github.com/CCExtractor/ccextractor/commit/7a4f4a8f79f1e22f056ef4faf52ec4301603be77) Remove thread.h (it doesn't needed) - [`cde884f`](https://github.com/CCExtractor/ccextractor/commit/cde884faae7bee837df11fdec77077b3e1138ea3) Merge branch 'master' of https://github.com/Hori75/ccextractor - [`9073396`](https://github.com/CCExtractor/ccextractor/commit/90733963e52587b3f5969842904065e99318ad62) Minor fix - [`a5f17c3`](https://github.com/CCExtractor/ccextractor/commit/a5f17c318d986978ed4cbd0431e48544ce5e62e1) Merge branch 'master' into libgpac - [`86a3980`](https://github.com/CCExtractor/ccextractor/commit/86a39802d397f50ef7d90eac69ad28cb6e0f5a03) Upgrade gpac to 0.7.1 - [`dfb26f4`](https://github.com/CCExtractor/ccextractor/commit/dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d) Modification to libgpac 0.7.1 - [`a473ef2`](https://github.com/CCExtractor/ccextractor/commit/a473ef2e92d22f4d95253c94a82f1072420f09cf) merge ### 📊 Changes **60 files changed** (+30940 additions, -21459 deletions) <details> <summary>View changed files</summary> 📝 `gsoc/skrill/first_phase_evaluation_script` (+0 -0) 📝 `linux/Makefile.am` (+6 -2) 📝 `linux/build` (+1 -1) 📝 `linux/build_hardsubx` (+1 -1) 📝 `linux/builddebug` (+1 -1) 📝 `mac/Makefile.am` (+6 -2) 📝 `mac/build.command` (+1 -1) 📝 `src/CMakeLists.txt` (+1 -1) 📝 `src/gpacmp4/av_parsers.c` (+1063 -832) 📝 `src/gpacmp4/avc_ext.c` (+435 -321) 📝 `src/gpacmp4/avilib.c` (+766 -776) 📝 `src/gpacmp4/box_code_3gpp.c` (+155 -305) 📝 `src/gpacmp4/box_code_adobe.c` (+87 -113) 📝 `src/gpacmp4/box_code_apple.c` (+62 -80) 📝 `src/gpacmp4/box_code_base.c` (+3300 -1780) 📝 `src/gpacmp4/box_code_drm.c` (+283 -373) 📝 `src/gpacmp4/box_code_meta.c` (+124 -174) ➕ `src/gpacmp4/box_dump.c` (+5180 -0) 📝 `src/gpacmp4/box_funcs.c` (+1220 -2663) ➕ `src/gpacmp4/color.c` (+2936 -0) _...and 40 more files_ </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Upgrade libgpac to <del>0.7.0</del> 0.7.1. The pr fixes the failing sample, **based on** @Hori75 **'s pr** #871 . List of changes I have made: (For future references when upgrading it...) - Change `box_funcs.c`: comment out some of the lines to avoid introduce too many files. See [dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d](https://github.com/CCExtractor/ccextractor/pull/894/commits/dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d) - In `gpac/configuration.h`, comment out all `#define GPAC_MEMORY_TRACKING` (there are currently two of it) and `#else #error "Unknown target platform used with static configuration file"` (To avoid compilation errors in Linux) - In `gpac/isomedia.h`, add more constants. See [dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d](https://github.com/CCExtractor/ccextractor/pull/894/commits/dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d) - Make `gpac/revision.h` yourself; update the version. - In `/gpac/setup.h`, change functions like `void* gf_malloc(size_t size);` to `#define gf_malloc malloc` (to avoid introducing `alloc.c`) - In `isom_write.c`, remove line `#include <gpac/iso639.h>` **Please don't merge until the CI platforms run it** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:14 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1734