[PR #898] [MERGED] [FEATURE] Support mp4 tx3g & multitrack subtitles #1735

Open
opened 2026-01-29 17:18:15 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/898
Author: @harrynull
Created: 1/13/2018
Status: Merged
Merged: 1/14/2018
Merged by: @cfsmp3

Base: masterHead: mp4


📝 Commits (4)

📊 Changes

3 files changed (+285 additions, -176 deletions)

View changed files

📝 src/gpacmp4/mp4.c (+267 -176)
📝 src/lib_ccx/ccx_encoders_common.c (+16 -0)
📝 src/lib_ccx/ccx_encoders_common.h (+2 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This will fix #807 .
FEATURE:

  • sbtl:tx3g and text:tx3g handler.
  • Support multitrack subtitles.

KNOWN ISSUES:

  • Styles & extensions of tx3g subtitles are ignored.
  • The empty default file will be created, even though sometimes(when there're multiple tracks) we don't use it.
  • -o outputfilename option is not honered. I don't think I caused it though. It seems to be broken long time ago.

NOTE:

  • I didn't test the situation when a sample has multiple atoms in it (Is it possible? I don't have a video sample to verify).
  • Although I think the timing is handled correctly, I don't have enough samples to verify.
  • All my local mp4 samples are extracted correctly, but I'd give the sample platform a go anyway.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/898 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 1/13/2018 **Status:** ✅ Merged **Merged:** 1/14/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `mp4` --- ### 📝 Commits (4) - [`904868e`](https://github.com/CCExtractor/ccextractor/commit/904868e9f6482629f1991673c37ada80a478dc84) Support mp4 tx3g & multitrack subtitles - [`73ab7db`](https://github.com/CCExtractor/ccextractor/commit/73ab7db6a6f5c5218fcd000c876cd142604c4f4d) Fix indentation - [`3cd0b71`](https://github.com/CCExtractor/ccextractor/commit/3cd0b717f80de08ead7b1417afe5d51460be5cbe) Minor changes - [`cb9ff19`](https://github.com/CCExtractor/ccextractor/commit/cb9ff19151bc7fc73bf44ccb517921cdf7282f4f) Add a comment ### 📊 Changes **3 files changed** (+285 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `src/gpacmp4/mp4.c` (+267 -176) 📝 `src/lib_ccx/ccx_encoders_common.c` (+16 -0) 📝 `src/lib_ccx/ccx_encoders_common.h` (+2 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- This will fix #807 . **FEATURE:** - sbtl:tx3g and text:tx3g handler. - Support multitrack subtitles. **KNOWN ISSUES:** - Styles & extensions of tx3g subtitles are ignored. - The empty default file will be created, even though sometimes(when there're multiple tracks) we don't use it. - `-o outputfilename` option is not honered. I don't think I caused it though. It seems to be broken long time ago. **NOTE:** - I didn't test the situation when a sample has multiple atoms in it (Is it possible? I don't have a video sample to verify). - Although I think the timing is handled correctly, I don't have enough samples to verify. - All my local mp4 samples are extracted correctly, but I'd give the sample platform a go anyway. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:15 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1735