[PR #925] [MERGED] [IMPROVEMENT] Code made compatible with Python 3 #1756

Open
opened 2026-01-29 17:18:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/925
Author: @thealphadollar
Created: 2/8/2018
Status: Merged
Merged: 2/9/2018
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (1)

  • 4480ab9 Upgrade code to be compatible with Python 3

📊 Changes

7 files changed (+24 additions, -12 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 api/api_support.py (+1 -0)
📝 api/api_testing.py (+2 -1)
📝 api/ccx_to_python_g608.py (+3 -1)
📝 api/python_srt_generator.py (+8 -5)
📝 api/recursive_tester.py (+5 -4)
📝 tools/histogram.py (+4 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Using the futurize library, the present python scripts of CCExtractor has been made compatible for Python 3 and Python 2 both. The minor changes introduced have been manually looked into for errors since I couldn't find a way to test them.

Also, the SWIG wrapping scripts have been checked to wrap for Python 3 with backward compatibility to python 2.

Implements #912


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/925 **Author:** [@thealphadollar](https://github.com/thealphadollar) **Created:** 2/8/2018 **Status:** ✅ Merged **Merged:** 2/9/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4480ab9`](https://github.com/CCExtractor/ccextractor/commit/4480ab991a7a20ddf0145c99b4d8bb67300f4159) Upgrade code to be compatible with Python 3 ### 📊 Changes **7 files changed** (+24 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `api/api_support.py` (+1 -0) 📝 `api/api_testing.py` (+2 -1) 📝 `api/ccx_to_python_g608.py` (+3 -1) 📝 `api/python_srt_generator.py` (+8 -5) 📝 `api/recursive_tester.py` (+5 -4) 📝 `tools/histogram.py` (+4 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Using the futurize library, the present python scripts of CCExtractor has been made compatible for Python 3 and Python 2 both. The minor changes introduced have been manually looked into for errors since I couldn't find a way to test them. Also, the SWIG wrapping scripts have been checked to wrap for Python 3 with backward compatibility to python 2. Implements #912 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1756