[PR #926] [MERGED] [FIX] DVB Teletext subtitle incomplete #922 #1757

Open
opened 2026-01-29 17:18:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/926
Author: @BPYap
Created: 2/8/2018
Status: Merged
Merged: 2/16/2018
Merged by: @cfsmp3

Base: masterHead: master


📝 Commits (8)

📊 Changes

1 file changed (+38 additions, -18 deletions)

View changed files

📝 src/lib_ccx/telxcc.c (+38 -18)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Attempt to solve issue #922 by replacing 0xB and 0xA in the middle of row with space character

Generated srt:
fixed

Playing the generated srt on windows 10 Movies & TV app:
geeignet


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/926 **Author:** [@BPYap](https://github.com/BPYap) **Created:** 2/8/2018 **Status:** ✅ Merged **Merged:** 2/16/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`bcffe2a`](https://github.com/CCExtractor/ccextractor/commit/bcffe2abb9d61874df0477561f694362297dfea8) solving [BUG] DVB Teletext subtitle incomplete #922 - [`6295496`](https://github.com/CCExtractor/ccextractor/commit/6295496d15a7f5234cf98e04374388667eb8d751) replace all 0xA characters within startbox with 0x20 - [`8ff8443`](https://github.com/CCExtractor/ccextractor/commit/8ff8443b5e246e3b98a2fcbf3c8a2dbc8b7d0c57) Fixing Bug #922 - [`9b0c12a`](https://github.com/CCExtractor/ccextractor/commit/9b0c12a1c24761c9765aded7fe7c8df4c0a5ac57) Fix Bug #922 - [`2258ab2`](https://github.com/CCExtractor/ccextractor/commit/2258ab23ef94c09a75a9da64a2da2b40438781aa) Fix Bug #922 - [`9385929`](https://github.com/CCExtractor/ccextractor/commit/93859297c1c3a01023e5372f15b3e68ad45e8a43) Fix Bug #922 - [`5d3e2cd`](https://github.com/CCExtractor/ccextractor/commit/5d3e2cdbb90b6fd1617c30c471988aa715b9dee4) Fixing Bug #922 - [`b7545e0`](https://github.com/CCExtractor/ccextractor/commit/b7545e0092c7370398855f773da702e22bde7bdd) Fix code indentation ### 📊 Changes **1 file changed** (+38 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/telxcc.c` (+38 -18) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Attempt to solve issue #922 by replacing 0xB and 0xA in the middle of row with space character Generated srt: ![fixed](https://user-images.githubusercontent.com/32807097/35971299-868bc1c8-0d08-11e8-8c11-0ff6d0f2c7a6.PNG) Playing the generated srt on windows 10 Movies & TV app: ![geeignet](https://user-images.githubusercontent.com/32807097/35971281-68460bc4-0d08-11e8-996e-9c6078a391fd.PNG) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1757