[PR #930] [MERGED] [FIX] Minor issue with spaces in teletext #1760

New Issue

claunia · 2026-01-29T17:18:24Z

claunia commented

2026-01-29 17:18:24 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/930
Author: @mkver
Created: 2/13/2018
Status: ✅ Merged
Merged: 2/14/2018
Merged by: @cfsmp3

Base: master ← Head: patch-1

📝 Commits (1)

e52ceb3 Update telxcc.c

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/lib_ccx/telxcc.c (+2 -1)

📄 Description

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I absolutely love CCExtractor, but have not contributed previously.

Currently setting a colour doesn't necessarily add a space even though the specifications mandate it. This commit is designed to change that.

This is designed to fix a different problem than #922. There is currently no space when the colour changes in teletext (except with --nofontcolor). See for example this sample which contains multiple instances of what I am talking about. The default output (with colours) contains the following (only lines that show this have been kept):

2
00:00:03,240 --> 00:00:06,039
<font color="#ffff00">Dann räumen wir</font>
<font color="#ffff00">mal aus, oder?</font><font color="#00ffff">Ja.</font>

4
00:00:18,200 --> 00:00:20,919
<font color="#00ff00">Toby, sag mal</font>
<font color="#00ff00">"Infrastruktur"!</font><font color="#ff00ff">"Infaschuktur".</font>


12
00:00:43,480 --> 00:00:46,319
<font color="#00ff00">Schön!</font>Und wie ist das so?

Whereas with --nofontcolor the output is:

2
00:00:03,240 --> 00:00:06,039
Dann räumen wir
mal aus, oder? Ja.

4
00:00:18,200 --> 00:00:20,919
Toby, sag mal
"Infrastruktur"! "Infaschuktur".

12
00:00:43,480 --> 00:00:46,319
Schön! Und wie ist das so?

As one sees without --nofontcolor there is no space between '?' and 'Ja' in the second line, between '!' and '"' in the fourth and between '!' and 'U' in the 12th line. This little patch adresses this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/930 **Author:** [@mkver](https://github.com/mkver) **Created:** 2/13/2018 **Status:** ✅ Merged **Merged:** 2/14/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e52ceb3`](https://github.com/CCExtractor/ccextractor/commit/e52ceb351686a6ba25369aaf4e0029c370e2248d) Update telxcc.c ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/telxcc.c` (+2 -1) </details> ### 📄 Description - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I absolutely love CCExtractor, but have not contributed previously. --- Currently setting a colour doesn't necessarily add a space even though the specifications mandate it. This commit is designed to change that. This is designed to fix a different problem than #922. There is currently no space when the colour changes in teletext (except with --nofontcolor). See for example [this sample](https://github.com/CCExtractor/ccextractor/files/1721771/Sample.zip) which contains multiple instances of what I am talking about. The default output (with colours) contains the following (only lines that show this have been kept): ``` 2 00:00:03,240 --> 00:00:06,039 Dann räumen wir mal aus, oder?Ja. 4 00:00:18,200 --> 00:00:20,919 Toby, sag mal "Infrastruktur"!"Infaschuktur". 12 00:00:43,480 --> 00:00:46,319 Schön!Und wie ist das so? ``` Whereas with --nofontcolor the output is: ``` 2 00:00:03,240 --> 00:00:06,039 Dann räumen wir mal aus, oder? Ja. 4 00:00:18,200 --> 00:00:20,919 Toby, sag mal "Infrastruktur"! "Infaschuktur". 12 00:00:43,480 --> 00:00:46,319 Schön! Und wie ist das so? ``` As one sees without --nofontcolor there is no space between '?' and 'Ja' in the second line, between '!' and '"' in the fourth and between '!' and 'U' in the 12th line. This little patch adresses this. --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

claunia added the pull-request label 2026-01-29 17:18:24 +00:00

claunia closed this issue

2026-01-29 17:18:25 +00:00

claunia referenced this issue

2026-01-29 17:22:23 +00:00

[PR #1760] [MERGED] build: add tesseract library linking for hardsubx feature #2480

claunia referenced this issue

2026-01-29 17:22:23 +00:00

[PR #1760] build: add tesseract library linking for hardsubx feature #2483

claunia referenced this issue

2026-01-29 17:22:55 +00:00

[PR #1829] [MERGED] build(autoconf): add tesseract/leptonica linking for HARDSUBX #2584