[PR #940] [CLOSED] [FIX] - Cmake compiliation issue with commit f717624b #1762

Open
opened 2026-01-29 17:18:25 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/940
Author: @achaudhary997
Created: 2/26/2018
Status: Closed

Base: masterHead: master


📝 Commits (3)

  • b3cd0fe Fixed f717624b
  • b176659 Merge branch 'hotfixf717624b'
  • 22072b6 Reverted all include headers which were added (to test where it is failing)

📊 Changes

2 files changed (+18 additions, -8 deletions)

View changed files

📝 src/lib_ccx/params.c (+9 -8)
tests/.gdb_history (+9 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

In the commit f717624b people were unable to compile the code using CMake. I have disabled the printing of utf8proc_version and fixed the included header files.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/940 **Author:** [@achaudhary997](https://github.com/achaudhary997) **Created:** 2/26/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`b3cd0fe`](https://github.com/CCExtractor/ccextractor/commit/b3cd0fe7043688fc8516e2bc571e09c1bd4f4cda) Fixed f717624b - [`b176659`](https://github.com/CCExtractor/ccextractor/commit/b176659f22c511fd77144da322f64a33b61bc0ed) Merge branch 'hotfixf717624b' - [`22072b6`](https://github.com/CCExtractor/ccextractor/commit/22072b658abfd7eb9ea1e24f68fc867238840c7a) Reverted all include headers which were added (to test where it is failing) ### 📊 Changes **2 files changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/params.c` (+9 -8) ➕ `tests/.gdb_history` (+9 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In the commit [f717624b](https://github.com/CCExtractor/ccextractor/commit/f717624bfac50b6bc3d637c383b1ede4072ccd4f) people were unable to compile the code using CMake. I have disabled the printing of utf8proc_version and fixed the included header files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:25 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1762