[PR #958] [MERGED] [FIX]-nocf not working with OCR'ing #1776

Open
opened 2026-01-29 17:18:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/958
Author: @thealphadollar
Created: 3/6/2018
Status: Merged
Merged: 3/6/2018
Merged by: @cfsmp3

Base: masterHead: resolve_nofc


📝 Commits (2)

  • 585c2f7 Fix -nocf not working with OCR'ing
  • da33122 remove dvbcolor and nodvbcolor parameter

📊 Changes

5 files changed (+3 additions, -19 deletions)

View changed files

📝 src/lib_ccx/ccx_common_option.c (+0 -1)
📝 src/lib_ccx/ccx_common_option.h (+0 -1)
📝 src/lib_ccx/ccx_encoders_splitbysentence.c (+1 -1)
📝 src/lib_ccx/ocr.c (+2 -1)
📝 src/lib_ccx/params.c (+0 -15)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fix #955

The addition of check for "tlt_config.nofontcolor" allows CCExtractor to skip detecting colors in the Optical Character Reading mode.

screenshot from 2018-03-07 01-05-55

arguments used for nofc:
-nofc -in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts

arguments used without nofc:
-in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/958 **Author:** [@thealphadollar](https://github.com/thealphadollar) **Created:** 3/6/2018 **Status:** ✅ Merged **Merged:** 3/6/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `resolve_nofc` --- ### 📝 Commits (2) - [`585c2f7`](https://github.com/CCExtractor/ccextractor/commit/585c2f7a01a6149fdad7125cae4e94cc75a3d488) Fix -nocf not working with OCR'ing - [`da33122`](https://github.com/CCExtractor/ccextractor/commit/da331224c8cbfa92a59bb7dad9ef8bc3c30d96fc) remove dvbcolor and nodvbcolor parameter ### 📊 Changes **5 files changed** (+3 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_option.c` (+0 -1) 📝 `src/lib_ccx/ccx_common_option.h` (+0 -1) 📝 `src/lib_ccx/ccx_encoders_splitbysentence.c` (+1 -1) 📝 `src/lib_ccx/ocr.c` (+2 -1) 📝 `src/lib_ccx/params.c` (+0 -15) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Fix #955 The addition of check for "tlt_config.nofontcolor" allows CCExtractor to skip detecting colors in the Optical Character Reading mode. ![screenshot from 2018-03-07 01-05-55](https://user-images.githubusercontent.com/32812320/37055462-cdb18318-21a7-11e8-8ebf-057469feb0a4.png) arguments used for nofc: `-nofc -in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts` arguments used without nofc: `-in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:30 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1776