[PR #950] [FIX] Fix segfault in add_cc_sub_text and initialize to NULL in init_encoder #1780

New Issue

claunia · 2026-01-29T17:18:30Z

claunia commented

2026-01-29 17:18:30 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/950

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This commit adds some checks to avoid segmentation faults.

In add_cc_sub_text(), strdup will cause a segfault if we duplicate an
empty string.
In init_encoder(), initialize pointer fields to NULL to avoid random
addressing so we can avoid illegal memory accessing and segfaults in
other places.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/950 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This commit adds some checks to avoid segmentation faults. * In `add_cc_sub_text()`, strdup will cause a segfault if we duplicate an empty string. * In `init_encoder()`, initialize pointer fields to NULL to avoid random addressing so we can avoid illegal memory accessing and segfaults in other places.

claunia added the pull-request label 2026-01-29 17:18:30 +00:00

claunia referenced this issue

2026-01-29 17:22:31 +00:00

[PR #1780] [MERGED] remove label -without-rust #2508

claunia referenced this issue

2026-01-29 17:22:32 +00:00

[PR #1780] remove label -without-rust #2511

Sign in to join this conversation.