[PR #971] [MERGED] [FIX] Correct -HARDSUBX Bug In CMake #1786

New Issue

claunia · 2026-01-29T17:18:32Z

claunia commented

2026-01-29 17:18:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/971
Author: @thealphadollar
Created: 4/1/2018
Status: ✅ Merged
Merged: 4/1/2018
Merged by: @cfsmp3

Base: master ← Head: rectify_bug

📝 Commits (1)

3f2f941 [FIX] Correct -HARDSUBX Bug In CMake

📊 Changes

1 file changed (+24 additions, -0 deletions)

View changed files

📝 src/lib_ccx/CMakeLists.txt (+24 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Currently, during the building process with the "-HARDSUBX" parameter (implemented in #966 ) and cmake, the below error pops up.

This error is caused since there is no setting for HARDSUBX in the CMAKELISTS.txt present inside the src/lib_ccx directory and hence the "-ENABLE_HARDSUBX" remains off.

This pull request fixes the error by adding the parameter and it's settings to the Cmake file.

[Tested independently on Digital Ocean server]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/971 **Author:** [@thealphadollar](https://github.com/thealphadollar) **Created:** 4/1/2018 **Status:** ✅ Merged **Merged:** 4/1/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `rectify_bug` --- ### 📝 Commits (1) - [`3f2f941`](https://github.com/CCExtractor/ccextractor/commit/3f2f9413040d7cfac1d963b7eff16c3dd559b43b) [FIX] Correct -HARDSUBX Bug In CMake ### 📊 Changes **1 file changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/CMakeLists.txt` (+24 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Currently, during the building process with the "-HARDSUBX" parameter (implemented in #966 ) and cmake, the below error pops up. ![screenshot from 2018-04-02 02-01-44](https://user-images.githubusercontent.com/32812320/38177242-c9a7760a-361b-11e8-912c-ffd595d01754.png) This error is caused since there is no setting for HARDSUBX in the CMAKELISTS.txt present inside the src/lib_ccx directory and hence the "-ENABLE_HARDSUBX" remains off. This pull request fixes the error by adding the parameter and it's settings to the Cmake file. [Tested independently on Digital Ocean server] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:32 +00:00

claunia closed this issue

2026-01-29 17:18:32 +00:00

claunia referenced this issue

2026-01-29 17:22:33 +00:00

[PR #1786] [MERGED] Fix G608 output extra NULL character (#1777) #2515

claunia referenced this issue

2026-01-29 17:22:34 +00:00

[PR #1786] Fix G608 output extra NULL character (#1777) #2519

Sign in to join this conversation.