[PR #991] [MERGED] Fix caption loss due to CW command #1796

New Issue

claunia · 2026-01-29T17:18:35Z

claunia commented

2026-01-29 17:18:35 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/991
Author: @thetransformerr
Created: 7/12/2018
Status: ✅ Merged
Merged: 7/17/2018
Merged by: @cfsmp3

Base: master ← Head: thetransformerr-patch-2

📝 Commits (3)

cc61d52 add code to copy window data before CW command
ec88dbe Update ccx_decoders_708.c
9d76728 Update ccx_decoders_708.c

📊 Changes

1 file changed (+15 additions, -2 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_708.c (+15 -2)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

[ x] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

[ x] I am an active contributor to CCExtractor.

Whenever ClearWindow command is issued to currently visible window , the captions stored in window are not copied to screen , since only toggle, hide window and delete window command do that right now , therefore data was out, with this PR , the caption are copied to screen and printed if there is some data and window was visible when Clearwindow was issued.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/991 **Author:** [@thetransformerr](https://github.com/thetransformerr) **Created:** 7/12/2018 **Status:** ✅ Merged **Merged:** 7/17/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `thetransformerr-patch-2` --- ### 📝 Commits (3) - [`cc61d52`](https://github.com/CCExtractor/ccextractor/commit/cc61d52f020f55287ceff2d657bf07b385db9d47) add code to copy window data before CW command - [`ec88dbe`](https://github.com/CCExtractor/ccextractor/commit/ec88dbebfc8bf0fe94d76fac59661bbb689bdd36) Update ccx_decoders_708.c - [`9d76728`](https://github.com/CCExtractor/ccextractor/commit/9d76728d3e0b215c1551f88c69a77c744f4d3195) Update ccx_decoders_708.c ### 📊 Changes **1 file changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_708.c` (+15 -2) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [ x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ x] I am an active contributor to CCExtractor. --- Whenever ClearWindow command is issued to currently visible window , the captions stored in window are not copied to screen , since only toggle, hide window and delete window command do that right now , therefore data was out, with this PR , the caption are copied to screen and printed if there is some data and window was visible when Clearwindow was issued. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:35 +00:00

claunia referenced this issue

2026-01-29 17:22:38 +00:00

[PR #1796] [MERGED] fix(ccx_decoders_common): add NULL checks and fix memory safety issues #2533

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1796