[PR #994] [MERGED] [IMPROVEMENT] Don't add files with empty filename & show better msg for multiple input files. #1800

New Issue

claunia · 2026-01-29T17:18:35Z

claunia commented

2026-01-29 17:18:35 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/994
Author: @saurabhshri
Created: 7/17/2018
Status: ✅ Merged
Merged: 12/18/2018
Merged by: @cfsmp3

Base: master ← Head: blank-inp-filenames

📝 Commits (1)

2dc5f4d Don't add files with empty filename. Also better message for multiple input files.

📊 Changes

4 files changed (+6 additions, -3 deletions)

View changed files

📝 src/ccextractor.c (+1 -1)
📝 src/lib_ccx/file_functions.c (+1 -1)
📝 src/lib_ccx/params.c (+2 -0)
📝 src/lib_ccx/params_dump.c (+2 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

If CCExtractor is passed an empty argument, it tries to open it as a file. E.g.
ccextractor "" OR
ccextractor {file1} "" {file2}

In case of multiple input files, if one or more failed to open, CCExtractor exists with the message Failed to open input file: File does not exist. Since my second parameter was an empty filename "" (came from an empty key in a script), I kept on thinking somehow "," is being appended to filename.
It showed : Input: filename,.

With this PR:

If filename is empty, that file is skipped.
If one or more file fails to open, it tells that.
Shows number of files while dumping parameters.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/994 **Author:** [@saurabhshri](https://github.com/saurabhshri) **Created:** 7/17/2018 **Status:** ✅ Merged **Merged:** 12/18/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `blank-inp-filenames` --- ### 📝 Commits (1) - [`2dc5f4d`](https://github.com/CCExtractor/ccextractor/commit/2dc5f4dd5ab430e854ec4b8851bcf0f6c20e7aa9) Don't add files with empty filename. Also better message for multiple input files. ### 📊 Changes **4 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/ccextractor.c` (+1 -1) 📝 `src/lib_ccx/file_functions.c` (+1 -1) 📝 `src/lib_ccx/params.c` (+2 -0) 📝 `src/lib_ccx/params_dump.c` (+2 -1) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- If CCExtractor is passed an empty argument, it tries to open it as a file. E.g. `ccextractor ""` OR `ccextractor {file1} "" {file2}` In case of multiple input files, if one or more failed to open, CCExtractor exists with the message `Failed to open input file: File does not exist.` Since my second parameter was an empty filename `""` (came from an empty key in a script), I kept on thinking somehow "," is being appended to filename. It showed : `Input: filename,`. With this PR: - If filename is empty, that file is skipped. - If one or more file fails to open, it tells that. - Shows number of files while dumping parameters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:35 +00:00

claunia closed this issue

2026-01-29 17:18:36 +00:00

claunia referenced this issue

2026-01-29 17:22:41 +00:00

[PR #1800] [MERGED] fix(708_output): replace sprintf with snprintf for buffer safety #2539

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1800