[PR #1057] [FIX] #995 for All platforms and removed the icons folder in source package

claunia commented

2026-01-29 17:18:56 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1057

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Made a singe function to take icon name and load the icon and also modified the relative loading of config files by the GUI executable.

This is actually a reopen of my previous pull request (#1050) as I had to change branch names in order to work on another issue and it screwed up my repo. Also I noticed that the general method required to return full path to executable in windows doesn't work if a 32-bit compiled application calls that function on a 64-bit OS, so in that case I've left the program to behave as it previously was.

I welcome any suggestions to help me fix the issue on Mac.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1057 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [X] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Made a singe function to take icon name and load the icon and also modified the relative loading of config files by the GUI executable. This is actually a reopen of my previous pull request (#1050) as I had to change branch names in order to work on another issue and it screwed up my repo. Also I noticed that the general method required to return full path to executable in windows doesn't work if a 32-bit compiled application calls that function on a 64-bit OS, so in that case I've left the program to behave as it previously was. I welcome any suggestions to help me fix the issue on Mac.

claunia added the pull-request label 2026-01-29 17:18:56 +00:00

claunia referenced this issue

2026-01-29 17:23:10 +00:00

[PR #1860] [MERGED] fix(docker): Rewrite Dockerfile to fix broken builds #2627

claunia referenced this issue

2026-01-29 17:23:11 +00:00

[PR #1860] fix(docker): Rewrite Dockerfile to fix broken builds #2630

[PR #1057] [FIX] #995 for All platforms and removed the icons folder in source package #1860