[PR #1059] [MERGED] [FIX] for issue #668 (Windows and Multicast)

claunia commented

2026-01-29 17:18:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1059
Author: @ShouryaAggarwal
Created: 12/21/2018
Status: ✅ Merged
Merged: 12/26/2018
Merged by: @cfsmp3

Base: master ← Head: Win_multicast_fix

📝 Commits (3)

c47d3f3 Fixed udp multicast stream issue on windows
aa03f9a Optimized OS detection for source multicast.
943f32e Moved the udp read code to networking.c file

📊 Changes

3 files changed (+43 additions, -4 deletions)

View changed files

📝 src/lib_ccx/file_functions.c (+2 -2)
📝 src/lib_ccx/networking.c (+40 -2)
📝 src/lib_ccx/networking.h (+1 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

So I read that in windows we need to bind to INADDR_ANY only while joining the multicast group, so I left it at that only. Now while receiving the stream from udp multicast, I peak at the header file and match the source ip with the provided ip and only continue if the IPs match. I have tested it on windows using ffmpeg stream system. Let me know if any more changes need to be done.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1059 **Author:** [@ShouryaAggarwal](https://github.com/ShouryaAggarwal) **Created:** 12/21/2018 **Status:** ✅ Merged **Merged:** 12/26/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `Win_multicast_fix` --- ### 📝 Commits (3) - [`c47d3f3`](https://github.com/CCExtractor/ccextractor/commit/c47d3f3c608c7ae480befdbbbb2551994b2558b6) Fixed udp multicast stream issue on windows - [`aa03f9a`](https://github.com/CCExtractor/ccextractor/commit/aa03f9a1cc2bd157b71ab90f541cdb58f88cfabe) Optimized OS detection for source multicast. - [`943f32e`](https://github.com/CCExtractor/ccextractor/commit/943f32e05c1ea6fb271133627288fadf84d80bc4) Moved the udp read code to networking.c file ### 📊 Changes **3 files changed** (+43 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/file_functions.c` (+2 -2) 📝 `src/lib_ccx/networking.c` (+40 -2) 📝 `src/lib_ccx/networking.h` (+1 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [X] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- So I read that in windows we need to bind to INADDR_ANY only while joining the multicast group, so I left it at that only. Now while receiving the stream from udp multicast, I peak at the header file and match the source ip with the provided ip and only continue if the IPs match. I have tested it on windows using ffmpeg stream system. Let me know if any more changes need to be done. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>