[PR #1092] [MERGED] [FIX] Remove webvtt styling when not using webvtt-full

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1092 **Author:** [@FossPrime](https://github.com/FossPrime) **Created:** 6/5/2019 **Status:** ✅ Merged **Merged:** 6/6/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `rayfoss-webvtt-styling` --- ### 📝 Commits (9) - [`5b711c6`](https://github.com/CCExtractor/ccextractor/commit/5b711c6407ffd8b29c90d5c1d69776d352fa2426) no styling unless in full mode - [`687cdda`](https://github.com/CCExtractor/ccextractor/commit/687cdda65264d7e4802ea41600fb6d42fbca5f58) part 1 of moving style to here - [`f8344a7`](https://github.com/CCExtractor/ccextractor/commit/f8344a727c6892f3ea75e68f5bc8e9909c69fb44) no style header unless requested with webvtt-full - [`7dd7386`](https://github.com/CCExtractor/ccextractor/commit/7dd73861b0532970dce924b66b323199edbd768c) only one new line to support x-timestamp-map - [`9ccb857`](https://github.com/CCExtractor/ccextractor/commit/9ccb8575fd004b365f8bce0ef38538749c5fa3d2) move x-timestamp-map up to abide by specifications - [`1bd1019`](https://github.com/CCExtractor/ccextractor/commit/1bd101913e4293f2ef2f71094f88aa26fa28c9d0) remove stray new line, crlfs are added upstream - [`98bc521`](https://github.com/CCExtractor/ccextractor/commit/98bc521010b07e37aaff09e09f6739705097c276) don't write null characters to sub file - [`df7a6d6`](https://github.com/CCExtractor/ccextractor/commit/df7a6d6a263e9262c6d8ee4a44215eed5d1959a1) needed space after -full mode style - [`4ea6734`](https://github.com/CCExtractor/ccextractor/commit/4ea6734a657dcfeaf244aa6e7362bb9f1020a0ee) typo ### 📊 Changes **2 files changed** (+23 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+22 -21) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- addresses #1076 leaves behind the null terminator bug, but it hasn't been an issue with anything except gedit as of yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:19:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1092
Author: @FossPrime
Created: 6/5/2019
Status: ✅ Merged
Merged: 6/6/2019
Merged by: @cfsmp3

Base: master ← Head: rayfoss-webvtt-styling

📝 Commits (9)

5b711c6 no styling unless in full mode
687cdda part 1 of moving style to here
f8344a7 no style header unless requested with webvtt-full
7dd7386 only one new line to support x-timestamp-map
9ccb857 move x-timestamp-map up to abide by specifications
1bd1019 remove stray new line, crlfs are added upstream
98bc521 don't write null characters to sub file
df7a6d6 needed space after -full mode style
4ea6734 typo

📊 Changes

2 files changed (+23 additions, -22 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_common.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+22 -21)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):