mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-14 21:23:42 +00:00
CEA-708 sentence capitalization #189
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cactusGit on GitHub (Sep 21, 2016).
It's missing. Looks like
clever_capitalizeandcorrect_case_with_dictionaryused only for other subs. I can make pull request with mostly copy-pasted code, but you could make it more architecturally correct.@cfsmp3 commented on GitHub (Sep 21, 2016):
Pending for now. In theory subtitles from 708 should be proper cased unless someone is really lazy.
I prefer to wait until 708 is stable (meaning subs extraction is good and we get to the point in which we prefer 708 over 608 every time) before adding features/bloat that makes code harder to debug.
@cfsmp3 commented on GitHub (Jan 20, 2017):
Closing, since it's not going to happen - it just doesn't seem needed for 708, I've been looking at lots of samples lately.