[PR #1101] [MERGED] [IMPROVEMENT] MXF caption frame rates #1896

Open
opened 2026-01-29 17:19:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1101
Author: @jgreer
Created: 8/15/2019
Status: Merged
Merged: 8/16/2019
Merged by: @cfsmp3

Base: masterHead: decode_mxf_cdp_frame_rates


📝 Commits (2)

  • 7fd455b Decode cdp frame rates in mxf files for accurate caption timings.
  • 4d44ffc Update changelog re: MXF frame rate parsing.

📊 Changes

2 files changed (+28 additions, -5 deletions)

View changed files

📝 docs/CHANGES.TXT (+4 -0)
📝 src/lib_ccx/ccx_demuxer_mxf.c (+24 -5)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Update the MXF demuxer so that it parses frame rates out of the CDP data. Without this, ccextractor assumed 29.97 fps in all content, so for example, on a 59.94 fps file the caption timings were double what they should be.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1101 **Author:** [@jgreer](https://github.com/jgreer) **Created:** 8/15/2019 **Status:** ✅ Merged **Merged:** 8/16/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `decode_mxf_cdp_frame_rates` --- ### 📝 Commits (2) - [`7fd455b`](https://github.com/CCExtractor/ccextractor/commit/7fd455b478c367f11cabddee08f7b473b186bb26) Decode cdp frame rates in mxf files for accurate caption timings. - [`4d44ffc`](https://github.com/CCExtractor/ccextractor/commit/4d44ffcaf782cbe979716b3213aba72725f34e65) Update changelog re: MXF frame rate parsing. ### 📊 Changes **2 files changed** (+28 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+4 -0) 📝 `src/lib_ccx/ccx_demuxer_mxf.c` (+24 -5) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Update the MXF demuxer so that it parses frame rates out of the CDP data. Without this, ccextractor assumed 29.97 fps in all content, so for example, on a 59.94 fps file the caption timings were double what they should be. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:08 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1896