[PR #1134] [MERGED] [FIX] Make header respect -lf for the webvtt encoder #1906

New Issue

claunia · 2026-01-29T17:19:12Z

claunia commented

2026-01-29 17:19:12 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1134
Author: @NilsIrl
Created: 12/5/2019
Status: ✅ Merged
Merged: 12/9/2019
Merged by: @cfsmp3

Base: master ← Head: newline

📝 Commits (4)

7fd0afd Make header respect -lf
610db13 [ccx_encoders_webvtt.c] Use the ternary operator to select line endings
184ba29 Use sprintf for choosing line ending and use ternary operator
b2631b8 Revert

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 src/ccextractor.c (+3 -3)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+3 -3)

📄 Description

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.
I have never used CCExtractor.

See title

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1134 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 12/5/2019 **Status:** ✅ Merged **Merged:** 12/9/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `newline` --- ### 📝 Commits (4) - [`7fd0afd`](https://github.com/CCExtractor/ccextractor/commit/7fd0afd92df0fc5fe474c79ee1a93259b228c54d) Make header respect `-lf` - [`610db13`](https://github.com/CCExtractor/ccextractor/commit/610db13bf040b7f22ee2af0708fa9c5f9d47decb) [ccx_encoders_webvtt.c] Use the ternary operator to select line endings - [`184ba29`](https://github.com/CCExtractor/ccextractor/commit/184ba29cc9601947875de3e1cab13a9b8b474a2b) Use sprintf for choosing line ending and use ternary operator - [`b2631b8`](https://github.com/CCExtractor/ccextractor/commit/b2631b8a896a30625948518625723a5cb7d11a26) Revert ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/ccextractor.c` (+3 -3) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+3 -3) </details> ### 📄 Description - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** - [X] I have never used CCExtractor. --- See title --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:12 +00:00

claunia closed this issue

2026-01-29 17:19:12 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1906

[PR #1134] [MERGED] [FIX] Make header respect -lf for the webvtt encoder #1906

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description

[PR #1134] [MERGED] [FIX] Make header respect `-lf` for the webvtt encoder #1906