[PR #1133] [MERGED] [FIX] Compilation warnings

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1133 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/5/2019 **Status:** ✅ Merged **Merged:** 12/9/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`d212a84`](https://github.com/CCExtractor/ccextractor/commit/d212a840ff918b15ca232619137dae5371594002) Add comments clarifying ccextractor.cnf and locale - [`6adcdda`](https://github.com/CCExtractor/ccextractor/commit/6adcdda1d6479da37a1219acebd85348ba569ec6) Comments on unobvious ctx entries - [`709c046`](https://github.com/CCExtractor/ccextractor/commit/709c046565cf08abc37ab40ccbbc4944b43aa72c) no_rollup explanation in ccx_s_options - [`d520a0a`](https://github.com/CCExtractor/ccextractor/commit/d520a0a53e68bbdf6caabbf75b3c0cf116d730b2) Unified mprint format. Removed obvious comment. - [`2c8aad4`](https://github.com/CCExtractor/ccextractor/commit/2c8aad435280b3546d4071b999c3b2b0c21e0c7e) Commented out unused lines and corrected if-clause - [`e2a11a5`](https://github.com/CCExtractor/ccextractor/commit/e2a11a516790a68c3b2527093b518c86628a133f) Changed unsigned char * to char * - [`1edc1f3`](https://github.com/CCExtractor/ccextractor/commit/1edc1f304a5f9103d490201bb7853c2713c7b59d) Returned to unsigned buffers - [`58e1efd`](https://github.com/CCExtractor/ccextractor/commit/58e1efd26ac27838c45abf0b2f13f2c8af8b557c) Unsigned buf converted to signed - [`ade128b`](https://github.com/CCExtractor/ccextractor/commit/ade128b8587c2ed8ee8b93ddfe15da2bd8a0dee9) Correct some lines causing warnings - [`5271702`](https://github.com/CCExtractor/ccextractor/commit/527170261e6eddba4e84abab316fcf98a804cd62) Added cases TODO. Some minor corrections. ### 📊 Changes **14 files changed** (+102 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+5 -0) 📝 `src/ccextractor.c` (+10 -6) 📝 `src/lib_ccx/ccx_common_option.c` (+4 -1) 📝 `src/lib_ccx/ccx_common_option.h` (+1 -1) 📝 `src/lib_ccx/ccx_decoders_708.c` (+5 -4) 📝 `src/lib_ccx/ccx_decoders_isdb.c` (+19 -8) 📝 `src/lib_ccx/ccx_decoders_xds.c` (+5 -4) 📝 `src/lib_ccx/ccx_demuxer_mxf.c` (+2 -2) 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -1) 📝 `src/lib_ccx/ccx_encoders_helpers.c` (+4 -0) 📝 `src/lib_ccx/ccx_encoders_mcc.c` (+2 -1) 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+41 -47) 📝 `src/lib_ccx/params_dump.c` (+2 -3) 📝 `src/zvbi/raw_decoder.c` (+1 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- I've fixed compilation warnings (through 1% to 27%). A big part of warnings are caused by (unsigned char *) being converted to other types. Is there really such a need to have buffers unsigned? Am I doing everything right or should I do it the other way? And how to resolve implicit type casting warnings with buffers? P.s: Also added some comments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:19:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1133
Author: @ghost
Created: 12/5/2019
Status: ✅ Merged
Merged: 12/9/2019
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (10+)

d212a84 Add comments clarifying ccextractor.cnf and locale
6adcdda Comments on unobvious ctx entries
709c046 no_rollup explanation in ccx_s_options
d520a0a Unified mprint format. Removed obvious comment.
2c8aad4 Commented out unused lines and corrected if-clause
e2a11a5 Changed unsigned char * to char *
1edc1f3 Returned to unsigned buffers
58e1efd Unsigned buf converted to signed
ade128b Correct some lines causing warnings
5271702 Added cases TODO. Some minor corrections.

📊 Changes

14 files changed (+102 additions, -79 deletions)

View changed files

📝 docs/CHANGES.TXT (+5 -0)
📝 src/ccextractor.c (+10 -6)
📝 src/lib_ccx/ccx_common_option.c (+4 -1)
📝 src/lib_ccx/ccx_common_option.h (+1 -1)
📝 src/lib_ccx/ccx_decoders_708.c (+5 -4)
📝 src/lib_ccx/ccx_decoders_isdb.c (+19 -8)
📝 src/lib_ccx/ccx_decoders_xds.c (+5 -4)
📝 src/lib_ccx/ccx_demuxer_mxf.c (+2 -2)
📝 src/lib_ccx/ccx_encoders_common.c (+1 -1)
📝 src/lib_ccx/ccx_encoders_helpers.c (+4 -0)
📝 src/lib_ccx/ccx_encoders_mcc.c (+2 -1)
📝 src/lib_ccx/ccx_encoders_smptett.c (+41 -47)
📝 src/lib_ccx/params_dump.c (+2 -3)
📝 src/zvbi/raw_decoder.c (+1 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

I've fixed compilation warnings (through 1% to 27%).
A big part of warnings are caused by (unsigned char *) being converted to other types.
Is there really such a need to have buffers unsigned?

Am I doing everything right or should I do it the other way? And how to resolve implicit type casting warnings with buffers?

P.s: Also added some comments.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}