[PR #1133] [FIX] Compilation warnings

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1910

claunia commented

2026-01-29 17:19:13 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1133

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

I've fixed compilation warnings (through 1% to 27%).
A big part of warnings are caused by (unsigned char *) being converted to other types.
Is there really such a need to have buffers unsigned?

Am I doing everything right or should I do it the other way? And how to resolve implicit type casting warnings with buffers?

P.s: Also added some comments.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1133 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- I've fixed compilation warnings (through 1% to 27%). A big part of warnings are caused by (unsigned char *) being converted to other types. Is there really such a need to have buffers unsigned? Am I doing everything right or should I do it the other way? And how to resolve implicit type casting warnings with buffers? P.s: Also added some comments.

claunia added the pull-request label 2026-01-29 17:19:13 +00:00

claunia referenced this issue

2026-01-29 17:23:29 +00:00

[PR #1910] Fix buffer truncation warnings in EPG time strings #2699

[PR #1133] [FIX] Compilation warnings #1910