[PR #1137] [CLOSED] [FIX] Add the X-TIMESTAMP-MAP header at all time to webvtt files. WIP #1916

Closed
opened 2026-01-29 17:19:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1137
Author: @NilsIrl
Created: 12/6/2019
Status: Closed

Base: masterHead: toggle_timestamp_#1127


📝 Commits (2)

  • a2b8abd Make X-TIMESTAMP-MAP appear even when no subtitles are present
  • 8607303 Add newline when no_timestamp_map == true

📊 Changes

7 files changed (+28 additions, -26 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_common.c (+5 -4)
📝 src/lib_ccx/ccx_encoders_common.h (+2 -1)
📝 src/lib_ccx/ccx_encoders_webvtt.c (+9 -11)
📝 src/lib_ccx/general_loop.c (+6 -4)
📝 src/lib_ccx/hardsubx.c (+1 -1)
📝 src/lib_ccx/lib_ccx.c (+4 -4)
📝 src/lib_ccx/lib_ccx.h (+1 -1)

📄 Description

Fix #1127

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have used CCExtractor just a couple of times.

Add the X-TIMESTAMP-MAP header at all time to webvtt files.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1137 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 12/6/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `toggle_timestamp_#1127` --- ### 📝 Commits (2) - [`a2b8abd`](https://github.com/CCExtractor/ccextractor/commit/a2b8abdfaf9980c7fc1fcc0524cf0b44b5ce367c) Make X-TIMESTAMP-MAP appear even when no subtitles are present - [`8607303`](https://github.com/CCExtractor/ccextractor/commit/8607303abed0c6abab73e9d6980c48b71a354a64) Add newline when no_timestamp_map == true ### 📊 Changes **7 files changed** (+28 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_common.c` (+5 -4) 📝 `src/lib_ccx/ccx_encoders_common.h` (+2 -1) 📝 `src/lib_ccx/ccx_encoders_webvtt.c` (+9 -11) 📝 `src/lib_ccx/general_loop.c` (+6 -4) 📝 `src/lib_ccx/hardsubx.c` (+1 -1) 📝 `src/lib_ccx/lib_ccx.c` (+4 -4) 📝 `src/lib_ccx/lib_ccx.h` (+1 -1) </details> ### 📄 Description Fix #1127 - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] I have used CCExtractor just a couple of times. Add the `X-TIMESTAMP-MAP` header at all time to webvtt files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:14 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1916