[PR #1149] [MERGED] [IMPROVEMENT] Minor styling improvement. #1930

New Issue

claunia · 2026-01-29T17:19:19Z

claunia commented

2026-01-29 17:19:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1149
Author: @ghost
Created: 12/11/2019
Status: ✅ Merged
Merged: 12/15/2019
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (5)

cbc28a7 Add, remove spaces. Optimise if-clause.
8099e68 Update cnf file. Correct and comment constants.
0befabd Unite style. Add/Remove spaces. Correct errors.
d10023c Add URLs to standards.
911b6c6 Correct order in enum.

📊 Changes

4 files changed (+1153 additions, -1120 deletions)

View changed files

📝 docs/ccextractor.cnf.sample (+30 -15)
📝 src/ccextractor.c (+53 -49)
📝 src/lib_ccx/ccx_common_constants.h (+86 -71)
📝 src/lib_ccx/params.c (+984 -985)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
[] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Motivation:
I was considering to do *scc, *ccd adding task, hence looked deeper in the code connected with it.
And I saw a lot of different styles, some minor errors, not well optimized if clauses, forgotten fatal-warnings, not updated cnf.sample file and so on.
To put all these corrections in *scc, *cdd pull request would not be a good idea, so here I am with that brand new pull request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1149 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/11/2019 **Status:** ✅ Merged **Merged:** 12/15/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`cbc28a7`](https://github.com/CCExtractor/ccextractor/commit/cbc28a7bddc9163f98b48c6f00ef8cb4e5469cbe) Add, remove spaces. Optimise if-clause. - [`8099e68`](https://github.com/CCExtractor/ccextractor/commit/8099e68efcc1f8f20659c78c13a11c97e71372a1) Update cnf file. Correct and comment constants. - [`0befabd`](https://github.com/CCExtractor/ccextractor/commit/0befabda77e3f7c1a89204ea6e286010a46cdde1) Unite style. Add/Remove spaces. Correct errors. - [`d10023c`](https://github.com/CCExtractor/ccextractor/commit/d10023c2f74d796717b2ed8ee6307f1fdfd6250b) Add URLs to standards. - [`911b6c6`](https://github.com/CCExtractor/ccextractor/commit/911b6c6120bafeca171fa7106c0e2e49941e41df) Correct order in enum. ### 📊 Changes **4 files changed** (+1153 additions, -1120 deletions) <details> <summary>View changed files</summary> 📝 `docs/ccextractor.cnf.sample` (+30 -15) 📝 `src/ccextractor.c` (+53 -49) 📝 `src/lib_ccx/ccx_common_constants.h` (+86 -71) 📝 `src/lib_ccx/params.c` (+984 -985) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Motivation: I was considering to do *scc, *ccd adding task, hence looked deeper in the code connected with it. And I saw a lot of different styles, some minor errors, not well optimized if clauses, forgotten fatal-warnings, not updated cnf.sample file and so on. To put all these corrections in *scc, *cdd pull request would not be a good idea, so here I am with that brand new pull request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:19 +00:00

claunia referenced this issue

2026-01-29 17:23:38 +00:00

[PR #1930] [MERGED] fix: Properly handle ATSC CC in private MPEG-2 streams #2730

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1930