[PR #1151] [MERGED] [FIX] Added back define to make building on Windows work again #1933

New Issue

claunia · 2026-01-29T17:19:19Z

claunia commented

2026-01-29 17:19:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1151
Author: @jshin313
Created: 12/17/2019
Status: ✅ Merged
Merged: 12/19/2019
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (1)

83b5838 Added back define to make building on Windows work again

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/utf8proc/utf8proc.h (+2 -0)

📄 Description

My familiarity with the project is as follows (check one):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Added back the define so that CCExtractor would build properly on Windows:

#define UTF8PROC_STATIC

in utf8proc.h

Tested on Windows 10 x64 using Visual Studio 2019.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1151 **Author:** [@jshin313](https://github.com/jshin313) **Created:** 12/17/2019 **Status:** ✅ Merged **Merged:** 12/19/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`83b5838`](https://github.com/CCExtractor/ccextractor/commit/83b5838017ec1fe4815b16bd9df08faef012a5d5) Added back define to make building on Windows work again ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/utf8proc/utf8proc.h` (+2 -0) </details> ### 📄 Description **My familiarity with the project is as follows (check one):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Added back the define so that CCExtractor would build properly on Windows: ``` #define UTF8PROC_STATIC ``` in utf8proc.h Tested on Windows 10 x64 using Visual Studio 2019. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:19 +00:00

claunia referenced this issue

2026-01-29 17:23:39 +00:00

[PR #1934] prevent heap buffer overflow in Teletext demux path #2735

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1933