[PR #1150] [CLOSED] [FIX] Fixing issues with building on Windows #1934

New Issue

claunia · 2026-01-29T17:19:20Z

claunia commented

2026-01-29 17:19:20 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1150
Author: @jshin313
Created: 12/17/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

77b76c4 Revert "[FIX]Update utf8proc (#1145)"

📊 Changes

3 files changed (+7094 additions, -7049 deletions)

View changed files

📝 src/utf8proc/utf8proc.c (+10 -12)
📝 src/utf8proc/utf8proc.h (+4 -8)
📝 src/utf8proc/utf8proc_data.c (+7080 -7029)

📄 Description

My familiarity with the project is as follows (check one):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

In the following the if-else statement didn't really make sense in utf8proc.h:

#  ifdef _WIN32
#    ifdef UTF8PROC_EXPORTS
#      define UTF8PROC_DLLEXPORT __declspec(dllexport)
#    else
#      define UTF8PROC_DLLEXPORT __declspec(dllexport)
#    endif

so the else case was changed to just # define UTF8PROC_DLLEXPORT. Previously, the latest CCExtractor source failed to build properly on Windows, but with this change, the source compiles correctly.

Tested on Windows 10 x64 using Visual Studio 2019.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1150 **Author:** [@jshin313](https://github.com/jshin313) **Created:** 12/17/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`77b76c4`](https://github.com/CCExtractor/ccextractor/commit/77b76c46cbfe83c94454deb18f2a73552076f762) Revert "[FIX]Update utf8proc (#1145)" ### 📊 Changes **3 files changed** (+7094 additions, -7049 deletions) <details> <summary>View changed files</summary> 📝 `src/utf8proc/utf8proc.c` (+10 -12) 📝 `src/utf8proc/utf8proc.h` (+4 -8) 📝 `src/utf8proc/utf8proc_data.c` (+7080 -7029) </details> ### 📄 Description **My familiarity with the project is as follows (check one):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In the following the if-else statement didn't really make sense in utf8proc.h: ``` # ifdef _WIN32 # ifdef UTF8PROC_EXPORTS # define UTF8PROC_DLLEXPORT __declspec(dllexport) # else # define UTF8PROC_DLLEXPORT __declspec(dllexport) # endif ``` so the else case was changed to just `# define UTF8PROC_DLLEXPORT`. Previously, the latest CCExtractor source failed to build properly on Windows, but with this change, the source compiles correctly. Tested on Windows 10 x64 using Visual Studio 2019. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:20 +00:00

claunia referenced this issue

2026-01-29 17:23:39 +00:00

[PR #1934] prevent heap buffer overflow in Teletext demux path #2735

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1934