[PR #1150] [FIX] Fixing issues with building on Windows #1937

New Issue

claunia · 2026-01-29T17:19:20Z

claunia commented

2026-01-29 17:19:20 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1150

State: closed
Merged: No

My familiarity with the project is as follows (check one):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

In the following the if-else statement didn't really make sense in utf8proc.h:

#  ifdef _WIN32
#    ifdef UTF8PROC_EXPORTS
#      define UTF8PROC_DLLEXPORT __declspec(dllexport)
#    else
#      define UTF8PROC_DLLEXPORT __declspec(dllexport)
#    endif

so the else case was changed to just # define UTF8PROC_DLLEXPORT. Previously, the latest CCExtractor source failed to build properly on Windows, but with this change, the source compiles correctly.

Tested on Windows 10 x64 using Visual Studio 2019.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1150 **State:** closed **Merged:** No --- **My familiarity with the project is as follows (check one):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In the following the if-else statement didn't really make sense in utf8proc.h: ``` # ifdef _WIN32 # ifdef UTF8PROC_EXPORTS # define UTF8PROC_DLLEXPORT __declspec(dllexport) # else # define UTF8PROC_DLLEXPORT __declspec(dllexport) # endif ``` so the else case was changed to just `# define UTF8PROC_DLLEXPORT`. Previously, the latest CCExtractor source failed to build properly on Windows, but with this change, the source compiles correctly. Tested on Windows 10 x64 using Visual Studio 2019.

claunia added the pull-request label 2026-01-29 17:19:20 +00:00

claunia closed this issue

2026-01-29 17:19:20 +00:00

claunia referenced this issue

2026-01-29 17:23:41 +00:00

[PR #1939] [MERGED] fix(rust): Fix 32-bit build failures (i686, armv7l) #2738

claunia referenced this issue

2026-01-29 17:23:42 +00:00

[PR #1939] fix(rust): Fix 32-bit build failures (i686, armv7l) #2742

Sign in to join this conversation.