[PR #1153] [MERGED] [IMPROVEMENT] Removed redundant check_configuration_file function

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1153 **Author:** [@MarcusGaiusPompey](https://github.com/MarcusGaiusPompey) **Created:** 12/21/2019 **Status:** ✅ Merged **Merged:** 12/22/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `redundant_function` --- ### 📝 Commits (2) - [`65a0555`](https://github.com/CCExtractor/ccextractor/commit/65a05551fca412b1bdf8f7abd6822b59c796a946) Removed redundant function - [`71eb8d7`](https://github.com/CCExtractor/ccextractor/commit/71eb8d7d644294b5d385ac5061bc9ff7bc711893) Updated changelog ### 📊 Changes **3 files changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/ccextractor.c` (+1 -6) 📝 `src/ccextractor.h` (+1 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- The `check_configuration_file` function takes in a dereferenced `ccx_s_options` struct as `api_options`, and calls `parse_configuration` by taking a reference to `api_options` . However, the only call to `check_configuration_file` is made by dereferencing a `ccx_s_options` struct, meaning `parse_configuration` can be called directly. Hence, there is no use for `check_configuration_file`, meaning it can be safely deleted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:19:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1153
Author: @MarcusGaiusPompey
Created: 12/21/2019
Status: ✅ Merged
Merged: 12/22/2019
Merged by: @cfsmp3

Base: master ← Head: redundant_function

📝 Commits (2)

65a0555 Removed redundant function
71eb8d7 Updated changelog

📊 Changes

3 files changed (+3 additions, -7 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/ccextractor.c (+1 -6)
📝 src/ccextractor.h (+1 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

The check_configuration_file function takes in a dereferenced ccx_s_options struct as api_options, and calls parse_configuration by taking a reference to api_options . However, the only call to check_configuration_file is made by dereferencing a ccx_s_options struct, meaning parse_configuration can be called directly. Hence, there is no use for check_configuration_file, meaning it can be safely deleted.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}